From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72489: 29.4.50; forward-comment not working as expected in toml-ts-mode Date: Sat, 17 Aug 2024 12:31:00 +0300 Message-ID: <861q2n4ht7.fsf@gnu.org> References: <86cymlq38q.fsf@gnu.org> <2BD4ADA2-2D9D-4D63-B08F-668EDF22193F@secure.kjonigsen.net> <52D8946D-CABF-413B-977E-F5FD96586509@secure.kjonigsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17515"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yang.yingchao@qq.com, 72489-done@debbugs.gnu.org, jostein@kjonigsen.net To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 17 11:32:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfFn7-0004Oa-OR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Aug 2024 11:32:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfFn0-0007Nj-EV; Sat, 17 Aug 2024 05:32:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfFmP-0007Jp-HI for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 05:31:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfFmO-0004nR-4b for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 05:31:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=gXGj9XkXUnkXtXE3JbsmuZt6eIgjfFQ/ZBI6DrvomVg=; b=HPd7uBozLnNJQ8ChSjXn9AXxchEx9Jh5G8leKsYtDR3c9Bsu0ICeCszx1goJwFWSyBJ+KyWAQK0Hekn8Zr3kq2YnaKc06e1Z9NrCeMv4OQf2LZOWu4vxG1T1JTISPyvnRHn9U58/rOR+LaHU+MpflBAZJYwK6XJu65j0UC3pePhjguurTuE/yp6ARiQ61ipt2MX2yPpIY5k7F75JsCrAqV/86p8RMvhIotkdXXSx7HlbH9V1auU3y2bI2pOxLhp4ARyQx2tEEY6XWGhEwO9F4pgCqbwmVxZ54JAY2G+PaWRzCyW0AUDLWDk7VLc38tbDMUFFR7l9KP3v+JBklp8umg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfFn0-0002el-PF for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 05:32:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2024 09:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72489 X-GNU-PR-Package: emacs Mail-Followup-To: 72489@debbugs.gnu.org, eliz@gnu.org, yang.yingchao@qq.com Original-Received: via spool by 72489-done@debbugs.gnu.org id=D72489.172388711010186 (code D ref 72489); Sat, 17 Aug 2024 09:32:02 +0000 Original-Received: (at 72489-done) by debbugs.gnu.org; 17 Aug 2024 09:31:50 +0000 Original-Received: from localhost ([127.0.0.1]:53505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFmo-0002eE-91 for submit@debbugs.gnu.org; Sat, 17 Aug 2024 05:31:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFml-0002dx-8b for 72489-done@debbugs.gnu.org; Sat, 17 Aug 2024 05:31:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfFm2-0004m9-UL; Sat, 17 Aug 2024 05:31:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=gXGj9XkXUnkXtXE3JbsmuZt6eIgjfFQ/ZBI6DrvomVg=; b=X6VLQdutmrQDFK87t9Cp eDKqs8NCOuRaCRakldqMyNLcDwmvE2E1AFMgcTgttl+CB6wr6klPBWBWMYSv7BgbcNyRkU3vzrVUi 11i0HwVuzAIBdxfze058+X0wdwEi90qZG3OhAMJ8WHGojKksAdycYJoxU0p8U6+THWQEc58Jftp+y fUDj4EHovZ/cn/rYGYCZDWNPMcYv0biArkICpxxuVxioufjiZtMiabLMbqbYaDQNrLPO+4zDqiCuJ 8XVjyw4Gc2j1XrJDSsKIcJMqwQiU6KIof80em/YguptUMBi5cs4lkMdoibPvE6U46seM6n3Xpq2u5 MuyXSvUuIalK/A==; In-Reply-To: <52D8946D-CABF-413B-977E-F5FD96586509@secure.kjonigsen.net> (message from Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= on Thu, 15 Aug 2024 12:10:46 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290245 Archived-At: > From: Jostein Kjønigsen > Date: Thu, 15 Aug 2024 12:10:46 +0200 > Cc: Eli Zaretskii , > "Mr. Jostein Kjønigsen" , > 72489@debbugs.gnu.org > > On 7 Aug 2024, at 03:02, Yang Yingchao wrote: > > I think the error in your case also proves the misbehavior of forward-comment, and it breaks > `uncomment-region' in my case. And with the suggested fix applied, and then recompile/evaluate, > `uncomment-region' works as expected. > > Yang: Have you loaded/compiled/provided the toml typescript-grammar before using this mode? > > The *-ts-modes depends on external grammar in order to properly initialize the major-mode and > provide correct highlighting and indentation. > > I only have the required shared libraries (libtree-sitter.so & libtree-sitter-toml.so) installed. This should > be enough, right? At least `treesit-explore-mode' works fine in toml buffer. > > Regards, > > -- *Yang Yingchao* > > I've recompiled from scratch and confirm this indeed fixes all issues mentioned. > > Eli: Feel free to apply the supplied patch. I still don't have commit access :) > > https://github.com/emacs-mirror/emacs/blob/e993e479c324bb720bca3f1cf194e55e32f01ccd/lisp/textmodes/toml-ts-mode.el#L53 > > > ``` > - (modify-syntax-entry ?\n "> b" table) > + (modify-syntax-entry ?\n ">" table) > ``` Thanks, installed on the emacs-30 branch, and closing the bug.