From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74111: [PATCH] New `tmm-menubar' shortcut display style Date: Thu, 31 Oct 2024 18:57:25 +0200 Message-ID: <861pzw2osq.fsf@gnu.org> References: <87r07xtuot.fsf@ledu-giraud.fr> <86sesc37x4.fsf@gnu.org> <87msikin17.fsf@ledu-giraud.fr> <86ikt835sc.fsf@gnu.org> <87ikt8ijc1.fsf@ledu-giraud.fr> <86a5ek2vtv.fsf@gnu.org> <87frocz2bd.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17858"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74111@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 31 17:58:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6YV3-0004QJ-Px for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Oct 2024 17:58:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6YUs-0006e2-Cj; Thu, 31 Oct 2024 12:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6YUk-0006dY-Kq for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 12:58:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6YUk-0007gy-C8 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 12:58:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=hUXZb9Cryb4XiWAPkvKsVe91Hc1Aarh2zJXaekorbsw=; b=dkHT6Dnm0RyhZTZTXesxGEL6GGBFBmCVIr5U0xIa1b9e54yo3re5pqktltR0lXhLr3rNo2J286BLSbGqH+V2MmxCBo316hrrKKXe9ppzbZy5cDQmKyYl7iBqqqwdKQndVTQnYHovv9x8pkXE8oT+6UotsMA0Vjp3Et6ov7ssmtXv7aTbMJ5ev4XlXPYwoTPirhJxScKGdvq27v9jYQr6bD5Rj50+v+r7EKM6Ksue/+GMtBMmECPkcUkazkt3r2Rk7cI/JjUxNxBo55iAOfnijcBIjfgnOO1ecGRljxgaT7Ybsv+FmfeLOoqo9jhIbUQYvwJqsPk5wge591jknCS9Ug==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6YUk-0007Xx-7I for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 12:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2024 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74111 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74111-submit@debbugs.gnu.org id=B74111.173039385628998 (code B ref 74111); Thu, 31 Oct 2024 16:58:02 +0000 Original-Received: (at 74111) by debbugs.gnu.org; 31 Oct 2024 16:57:36 +0000 Original-Received: from localhost ([127.0.0.1]:43116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6YUK-0007Xe-6v for submit@debbugs.gnu.org; Thu, 31 Oct 2024 12:57:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6YUI-0007XY-Pf for 74111@debbugs.gnu.org; Thu, 31 Oct 2024 12:57:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6YUC-0007aq-PS; Thu, 31 Oct 2024 12:57:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hUXZb9Cryb4XiWAPkvKsVe91Hc1Aarh2zJXaekorbsw=; b=Ohb0WijiHOtD 9o9N/xONT06ZbPOfw0y0kBU8DO9D7bK90wCY8QFPMjvOORNnmqtqrf9Dh9vTKRTIRZI06txNFrSQu KP0LIOAaE4kWBqaWSZx1gyiZAYfqRrCcSYsUu7uJGTdM1Y5eIKcfTA52EKnYNX8E0evndDTEcMsyw NezpaHQEN6uMpLWycU3vjgKXPfB3LZwrz0L8LWGWjYumgJTcNU/FRXLoyFwRStKgc6zmsfJgI2sXP iDwcc5TEBVTVAcxxJv8LoKuv6/IFGgRxPhXxlMSWXH3URDrO15gqH/nrLSALm+eeWDksl0Sa3JCSJ Gkn3Zkq1TCGn02YDjMmMiw==; In-Reply-To: <87frocz2bd.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 31 Oct 2024 17:04:22 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294632 Archived-At: > From: Manuel Giraud > Cc: 74111@debbugs.gnu.org > Date: Thu, 31 Oct 2024 17:04:22 +0100 > > >> Maybe we could change it to "highlighted letters (or digits)". But > >> FWIW, "marked letters" was not really more clear before this patch. So > >> I think we could try to rewrite tmm-completion-prompt with something > >> clearer that work for both options. WDYT? > > > > I agree, please suggest a better text that caters to both cases. > > What do you think of this new version of the patch? LGTM, thanks. > I removed the > "PageUp" comment as it does not seem to work (while 'M-v' is) PageUp does work here, so I think we should leave that sentence, but modify it to say "M-v/PageUp". > +*** New user option 'tmm-shortcut-inside-entry'. > +When non-nil, insert the character shortcut of a menu entry inside its The "insert...inside its string" is not really accurate, is it? The code tries to highlight a character that already exists in the choice string, and prepends a digit if it fails to find such a character. > +(defcustom tmm-shortcut-inside-entry nil > + "Place the shortcut character into the menu entry's string. > +When non-nil, the shortcut character will be inserted into its menu > +entry string with a different face to help identifying it. The > +`tmm-mid-prompt' string is not used then." Same here.