bug#74111: [PATCH] New `tmm-menubar' shortcut display style

[Eli Zaretskii <eliz@gnu.org>]

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 74111@debbugs.gnu.org
> Date: Thu, 31 Oct 2024 17:04:22 +0100
> 
> >> Maybe we could change it to "highlighted letters (or digits)".  But
> >> FWIW, "marked letters" was not really more clear before this patch.  So
> >> I think we could try to rewrite tmm-completion-prompt with something
> >> clearer that work for both options.  WDYT?
> >
> > I agree, please suggest a better text that caters to both cases.
> 
> What do you think of this new version of the patch?

LGTM, thanks.

> I removed the
> "PageUp" comment as it does not seem to work (while 'M-v' is)

PageUp does work here, so I think we should leave that sentence, but
modify it to say "M-v/PageUp".

> +*** New user option 'tmm-shortcut-inside-entry'.
> +When non-nil, insert the character shortcut of a menu entry inside its

The "insert...inside its string" is not really accurate, is it?  The
code tries to highlight a character that already exists in the choice
string, and prepends a digit if it fails to find such a character.

> +(defcustom tmm-shortcut-inside-entry nil
> +  "Place the shortcut character into the menu entry's string.
> +When non-nil, the shortcut character will be inserted into its menu
> +entry string with a different face to help identifying it.  The
> +`tmm-mid-prompt' string is not used then."

Same here.