all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 74111@debbugs.gnu.org
Subject: bug#74111: [PATCH] New `tmm-menubar' shortcut display style
Date: Thu, 31 Oct 2024 18:57:25 +0200	[thread overview]
Message-ID: <861pzw2osq.fsf@gnu.org> (raw)
In-Reply-To: <87frocz2bd.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 31 Oct 2024 17:04:22 +0100)

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 74111@debbugs.gnu.org
> Date: Thu, 31 Oct 2024 17:04:22 +0100
> 
> >> Maybe we could change it to "highlighted letters (or digits)".  But
> >> FWIW, "marked letters" was not really more clear before this patch.  So
> >> I think we could try to rewrite tmm-completion-prompt with something
> >> clearer that work for both options.  WDYT?
> >
> > I agree, please suggest a better text that caters to both cases.
> 
> What do you think of this new version of the patch?

LGTM, thanks.

> I removed the
> "PageUp" comment as it does not seem to work (while 'M-v' is)

PageUp does work here, so I think we should leave that sentence, but
modify it to say "M-v/PageUp".

> +*** New user option 'tmm-shortcut-inside-entry'.
> +When non-nil, insert the character shortcut of a menu entry inside its

The "insert...inside its string" is not really accurate, is it?  The
code tries to highlight a character that already exists in the choice
string, and prepends a digit if it fails to find such a character.

> +(defcustom tmm-shortcut-inside-entry nil
> +  "Place the shortcut character into the menu entry's string.
> +When non-nil, the shortcut character will be inserted into its menu
> +entry string with a different face to help identifying it.  The
> +`tmm-mid-prompt' string is not used then."

Same here.





      reply	other threads:[~2024-10-31 16:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 16:35 bug#74111: [PATCH] New `tmm-menubar' shortcut display style Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31  9:46 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 10:04 ` Eli Zaretskii
2024-10-31 10:28   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 10:50     ` Eli Zaretskii
2024-10-31 11:48       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 14:25         ` Eli Zaretskii
2024-10-31 16:04           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 16:57             ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861pzw2osq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74111@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.