From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75422: 30.0.93; [PATCH] forward-sexp and backward-sexp jump outside of comments in tsx-ts-mode Date: Wed, 08 Jan 2025 15:12:32 +0200 Message-ID: <861pxd4fgf.fsf@gnu.org> References: <87ldvmjz7o.fsf@mail.linkov.net> <07F33B09-D0C4-4C6A-8F80-10E2173D92FF@gmail.com> <87frltlpfz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11616"; mail-complaints-to="usenet@ciao.gmane.io" Cc: seventhepg@gmail.com, casouri@gmail.com, 75422@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 08 14:13:37 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVVsO-0002q5-So for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jan 2025 14:13:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVVrv-0007x1-Rd; Wed, 08 Jan 2025 08:13:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVVrr-0007vd-Iv for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 08:13:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVVrr-0005iX-92 for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 08:13:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=HRxzeMGLgGNLfeThpgiOEJfnn+upC7J16eYa0sEBpM8=; b=Q5VG1hGSu7aYdfk/0MZRvT/1X4kurEQncth/vdldA06az7TpgyDMpwECG6wcih1lCoDKLZwLgXTT5ZGDxf/icm5GqnpiS27DAutlj+d72lPKol1ZyMvf6vlYqnOKPg3nwI16Pt0KBBK9VuE+rUDFN0DZPo1sm4Tdx++lTg9XpzG9VOviC9vgZHdK/yVswTnxWQjxPrbXyOipo686T3znjMexnX6JSetNTrv+I+76NQPHHwcSTARqfFBrWIM04XdhaDLqKtUpHQCn1x5Rk4fcwtYeEzTQGGwPuynzF0vOeOl/ACOU2oWjE2pbeN0cmAvFSVJdnsOlG9E9yqNbrgih8g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVVrr-0002Ai-29 for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 08:13:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2025 13:13:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75422-submit@debbugs.gnu.org id=B75422.17363419698314 (code B ref 75422); Wed, 08 Jan 2025 13:13:03 +0000 Original-Received: (at 75422) by debbugs.gnu.org; 8 Jan 2025 13:12:49 +0000 Original-Received: from localhost ([127.0.0.1]:46426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVVrc-0002A2-Qu for submit@debbugs.gnu.org; Wed, 08 Jan 2025 08:12:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54624) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVVra-00029o-Mr for 75422@debbugs.gnu.org; Wed, 08 Jan 2025 08:12:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVVrU-0005f4-KK; Wed, 08 Jan 2025 08:12:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HRxzeMGLgGNLfeThpgiOEJfnn+upC7J16eYa0sEBpM8=; b=bxOBwnRC2/DqEPsCJiH8 AD/8z6MeYH/MhJLB0RJRYSvo1D/ijyWglRN4vddgz6ws0YyQFfUXSG3afuj/C96SnspLRVf7BKyA5 La6KZzZdXPDGRUhv1uRuSAFPXUuBJAeBev5A+1XIJu8546IrASIhPwlJ0vmvPd3lHZpNyQxMxiMfu knhnsRVCYPi1tbgHnVbEdloc2jtwVPTJdVxaEprSVbGQiuHNpzBcXIjYLUDHEJArArC36wwk8BErV zCCXcer6f+qdJwFlfBTQtTGphicTMde92cZ3QyY2PkNu3erPLz38S5glNtFpVcdSUOQ0Rz2rxnRV0 Myps7mqoqPy+qw==; In-Reply-To: <87frltlpfz.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 08 Jan 2025 09:44:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298777 Archived-At: > From: Juri Linkov > Cc: Kohei Tsuruta , 75422@debbugs.gnu.org, Eli > Zaretskii > Date: Wed, 08 Jan 2025 09:44:48 +0200 > > >>> --- a/lisp/progmodes/typescript-ts-mode.el > >>> +++ b/lisp/progmodes/typescript-ts-mode.el > >>> @@ -564,7 +564,9 @@ tsx-ts-mode > >>> (sentence ,(regexp-opt > >>> (append typescript-ts-mode--sentence-nodes > >>> '("jsx_element" > >>> - "jsx_self_closing_element"))))))) > >>> + "jsx_self_closing_element")))) > >>> + (text ,(regexp-opt '("comment" > >>> + "template_string")))))) > > > > I think it’s fine. Though it’s for Eli to decide. > > Eli, is it ok to push this patch to emacs-30? Yes, thanks.