all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Yue Yi" <include_yy@qq.com>
Cc: 76041@debbugs.gnu.org
Subject: bug#76041: 31.0.50; comments above creating reader_thread in w32proc.c can be improved
Date: Tue, 04 Feb 2025 15:45:59 +0200	[thread overview]
Message-ID: <861pwdbz6w.fsf@gnu.org> (raw)
In-Reply-To: <tencent_55FFC1951C1FAF482ABBA09538A738E5BF0A@qq.com> (bug-gnu-emacs@gnu.org)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1128 bytes --]

> Date: Tue, 4 Feb 2025 12:54:51 +0800
> From:  "Yue Yi" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> On May 28, 2014, Fabrice Popineau replaced GNU's malloc with the
> system¡¯s allocation functions in commit 587fd08, and allocate_heap
> was removed. Therefore, I believe the above comment is somewhat
> outdated.
> 
> My suggestion is to remove the 2GB-related part in the
> comment.

Yes, okay.

> Allocating a small amount of stack space for each
> reader_thread still makes sense, because excessive threads would
> consume too much address space on a 32-bit system.

Right.  In particular, if we want to support 1024 subprocesses, which
means more than 1000 threads, giving 8MB of stack to each of those
threads is impossible for 32-bit Emacs.

> Additionally, I noticed the recent merge of no-purespace, which
> removed support for unexec. The alias for RtlCreateHeap_Proc in
> win32heap.c and the related comment seem to be redundant now.

That's true, but let's wait with removing these until Po Lu says he's
done with handling the fallout of unexec removal.





      reply	other threads:[~2025-02-04 13:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04  4:54 bug#76041: 31.0.50; comments above creating reader_thread in w32proc.c can be improved Yue Yi via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-02-04 13:45 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861pwdbz6w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=76041@debbugs.gnu.org \
    --cc=include_yy@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.