Adding M-x iwconfig to net-utils.el

Adding M-x iwconfig to net-utils.el

[Yoni Rabkin]

Hello,

I've added to wireless.el (a small library of mine) the ability to call
iwconfig diagnostically via "M-x iwconfig", as per the interface
net-utils.el provides to ifconfig, netstat etc.

It occurs to me that the right place for this might be in net-utils.el
itself.

If people agree that this is worth adding, I will gladly send in the
trivial patch against net-utils.el which does this.

-- 
   "Cut your own wood and it will warm you twice"

Re: Adding M-x iwconfig to net-utils.el

[Miles Bader]

Yoni Rabkin <yoni@rabkins.net> writes:
> I've added to wireless.el (a small library of mine) the ability to call
> iwconfig diagnostically via "M-x iwconfig", as per the interface
> net-utils.el provides to ifconfig, netstat etc.

BTW, why does net-utils.el constantly refer to it as "ipconfig", when
clearly it's running "ifconfig"?  Every system I've ever used has called
it "ifconfig", so it seems very weird...

-Miles

-- 
Alone, adj. In bad company.

Re: Adding M-x iwconfig to net-utils.el

[Yoni Rabkin]

Miles Bader <miles.bader@necel.com> writes:

> Yoni Rabkin <yoni@rabkins.net> writes:
>> I've added to wireless.el (a small library of mine) the ability to call
>> iwconfig diagnostically via "M-x iwconfig", as per the interface
>> net-utils.el provides to ifconfig, netstat etc.
>
> BTW, why does net-utils.el constantly refer to it as "ipconfig", when
> clearly it's running "ifconfig"?  Every system I've ever used has called
> it "ifconfig", so it seems very weird...

It must be a Microsoft Windows thing, since the net-utils.el code says:

(defcustom ipconfig-program
  (if (eq system-type 'windows-nt)
      "ipconfig"
    "ifconfig")
...

-- 
   "Cut your own wood and it will warm you twice"

Re: Adding M-x iwconfig to net-utils.el

[Miles Bader]

Yoni Rabkin <yoni@rabkins.net> writes:
>> BTW, why does net-utils.el constantly refer to it as "ipconfig", when
>> clearly it's running "ifconfig"?  Every system I've ever used has called
>> it "ifconfig", so it seems very weird...
>
> It must be a Microsoft Windows thing, since the net-utils.el code says:
>
> (defcustom ipconfig-program
>   (if (eq system-type 'windows-nt)
>       "ipconfig"
>     "ifconfig")

Yuck...  Emacs shouldn't be using windows-influenced names, I think.

-Miles

-- 
Philosophy, n. A route of many roads leading from nowhere to nothing.

Re: Adding M-x iwconfig to net-utils.el

[Yoni Rabkin]

Miles Bader <miles.bader@necel.com> writes:

> Yoni Rabkin <yoni@rabkins.net> writes:
>>> BTW, why does net-utils.el constantly refer to it as "ipconfig", when
>>> clearly it's running "ifconfig"?  Every system I've ever used has called
>>> it "ifconfig", so it seems very weird...
>>
>> It must be a Microsoft Windows thing, since the net-utils.el code says:
>>
>> (defcustom ipconfig-program
>>   (if (eq system-type 'windows-nt)
>>       "ipconfig"
>>     "ifconfig")
>
> Yuck...  Emacs shouldn't be using windows-influenced names, I think.

That can be added to my proposed patch easily enough, or as an
additional trivial patch.

It would also probably change the name of the buffer and the current
net-utils.el alias:

;; This is the normal name on most Unixes.
;;;###autoload
(defalias 'ifconfig 'ipconfig)

...to:

;; This is the the name of the command on Windows NT.
;;;###autoload
(defalias 'ipconfig 'ifconfig)

-- 
   "Cut your own wood and it will warm you twice"

Re: Adding M-x iwconfig to net-utils.el

[Richard Stallman]

    (defcustom ipconfig-program
      (if (eq system-type 'windows-nt)
	  "ipconfig"
	"ifconfig")

Emacs should follow the practices of the GNU system, not Windows.
So this variable should be called ifconfig-program.

I changed that and related names.

Re: Adding M-x iwconfig to net-utils.el

[Glenn Morris]

Richard Stallman wrote:

> Emacs should follow the practices of the GNU system, not Windows.
> So this variable should be called ifconfig-program.
>
> I changed that and related names.

And I added some variable aliases to avoid punishing users of this
package for a mistake outside their control.


PS. It's funny how people often switch to the past tense when writing
certain ChangeLog entries (eg: "rename", "move").

Re: Adding M-x iwconfig to net-utils.el

[Miles Bader]

Glenn Morris <rgm@gnu.org> writes:
> PS. It's funny how people often switch to the past tense when writing
> certain ChangeLog entries (eg: "rename", "move").

Not as funny as people obsessing over the tense of changelog
entries... :-)

-Miles

-- 
Education, n. That which discloses to the wise and disguises from the foolish
their lack of understanding.

Re: Adding M-x iwconfig to net-utils.el

[Glenn Morris]

Miles Bader wrote:

> Not as funny as people obsessing over the tense of changelog
> entries... :-)

I confess. :)

Re: Adding M-x iwconfig to net-utils.el

[Stefan Monnier]

>> PS. It's funny how people often switch to the past tense when writing
>> certain ChangeLog entries (eg: "rename", "move").
> Not as funny as people obsessing over the tense of changelog
> entries... :-)

Are you calling me obsessive?


        Stefan

Re: Adding M-x iwconfig to net-utils.el

[Miles Bader]

Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Not as funny as people obsessing over the tense of changelog
>> entries... :-)
>
> Are you calling me obsessive?

In the best possible way...

-Miles

-- 
"Don't just question authority,
Don't forget to question me."
-- Jello Biafra

Re: Adding M-x iwconfig to net-utils.el

[Stephen J. Turnbull]

Stefan Monnier writes:
 > >> PS. It's funny how people often switch to the past tense when writing
 > >> certain ChangeLog entries (eg: "rename", "move").
 > > Not as funny as people obsessing over the tense of changelog
 > > entries... :-)
 > 
 > Are you calling me obsessive?

No, he said you lighten up his day, even with your comments on others'
ChangeLogs.

Re: Adding M-x iwconfig to net-utils.el

[Juanma Barranquero]

> Are you calling me obsessive?

Well, then what's he calling me? I worry even about *whitespace* in
the ChangeLogs... :)

             Juanma

Re: Adding M-x iwconfig to net-utils.el

[Richard Stallman]

    PS. It's funny how people often switch to the past tense when writing
    certain ChangeLog entries (eg: "rename", "move").

I have always used "deleted" and "renamed", past tense.

Re: Adding M-x iwconfig to net-utils.el

[Glenn Morris]

Richard Stallman wrote:

>     PS. It's funny how people often switch to the past tense when writing
>     certain ChangeLog entries (eg: "rename", "move").
>
> I have always used "deleted" and "renamed", past tense.

I could have sworn there was a GNU or Emacs standard that said "write
changelog entries in the present tense", but now that I look I can't
find it. :(

All I can find is lispref/tips.texi saying to write doc-strings in the
present tense.

Re: Adding M-x iwconfig to net-utils.el

[Alfred M. Szmidt]

   >     PS. It's funny how people often switch to the past tense when
   >     writing certain ChangeLog entries (eg: "rename", "move").
   >
   > I have always used "deleted" and "renamed", past tense.

   I could have sworn there was a GNU or Emacs standard that said
   "write changelog entries in the present tense", but now that I look
   I can't find it. :(

I seem to recall something similar, but neither the GNU Coding
Standards nor the much pickier GNITS standards say anything about it!

Re: Adding M-x iwconfig to net-utils.el

[David Kastrup]

Richard Stallman <rms@gnu.org> writes:

>     PS. It's funny how people often switch to the past tense when writing
>     certain ChangeLog entries (eg: "rename", "move").
>
> I have always used "deleted" and "renamed", past tense.

One can argue about the "past tense" of "deleted xxx.c", since it can be
short hand for "xxx.c is deleted" (clearly present tense) or "I have
deleted xxx.c" (perfect tense, describing the current state).

The grammar of verb-less sentence fragments is at least debatable.  Not
that I want to propose debating it: I don't think there is anything that
needs fixing in current practice.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum