From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#15112: 24.3; package.el byte compile autoloads Date: Wed, 28 Aug 2019 10:48:24 -0400 Message-ID: <85zhjtibwn.fsf@gmail.com> References: <8738q96sb1.fsf@blah.blah> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="54275"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) Cc: Kevin Ryde , 15112@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 28 16:49:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2zG3-000Dwy-Up for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Aug 2019 16:49:12 +0200 Original-Received: from localhost ([::1]:37214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2zG2-0004Zj-Qz for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Aug 2019 10:49:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33210) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2zFv-0004ZQ-5Q for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 10:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2zFu-0004mT-7O for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 10:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2zFu-0004mA-3d for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 10:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2zFt-00072L-Un for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 10:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Aug 2019 14:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15112 X-GNU-PR-Package: emacs Original-Received: via spool by 15112-submit@debbugs.gnu.org id=B15112.156700371527014 (code B ref 15112); Wed, 28 Aug 2019 14:49:01 +0000 Original-Received: (at 15112) by debbugs.gnu.org; 28 Aug 2019 14:48:35 +0000 Original-Received: from localhost ([127.0.0.1]:51035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2zFS-00071d-N5 for submit@debbugs.gnu.org; Wed, 28 Aug 2019 10:48:34 -0400 Original-Received: from mail-io1-f46.google.com ([209.85.166.46]:44666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2zFO-00071O-M0 for 15112@debbugs.gnu.org; Wed, 28 Aug 2019 10:48:31 -0400 Original-Received: by mail-io1-f46.google.com with SMTP id j4so6306642iog.11 for <15112@debbugs.gnu.org>; Wed, 28 Aug 2019 07:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2G1SXDT9OoLkAtMLz4LF6wxufDsjrI64aBdJd86nWBg=; b=eBWbXsDqVow3f7EhjPmYb4fWWPzje7vVpQoceAKOzEZAPbHFYXZ60EKBoBk8c4Wh45 V2BBhFQsF0OnrZ4GiVlb7QU4T7Gg+Vu2vEupJSNHF0SNPr67Np9qz+ubKKvvZ/KY0tw6 AVRZkGVIFdjYl//YQypdzK6R1cKIKtI1m+V70gSvcBaRQAArveh2J3S0dCljiVDkegoS bUrK1mrHOG6+qgOujVUonBgcKuqVi49BhoKF06hxsDPWSyYOkuAt7ePU39i5Zh6R6QaL KqP1vv9zFyCBZAmZ05F7oGnon/v+kLyEQ4Fw1yRoNjlKu+OX1iu3XOLjasnvKDEVXABY sqNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2G1SXDT9OoLkAtMLz4LF6wxufDsjrI64aBdJd86nWBg=; b=XzpBFNOMGFONs2V6nhrWwfsEej5d3sffYKvuulp1WCEeCJ+fElA3Q7eldT77eBoc5+ +1wniIvEP1J932FhHweKhxLBfl2RRGHBLHeGQ31ddRk9vY6TZGlExj4P7HaOJl9El996 iB4nz6uV5ufgjWQ+OSjBK8ZJ8Gj4q/yXzXWwoPfA9/jfAgGQ5MWCUUoakUBsdCGpOcRS rXBlTO8JSSEtu3QRrdTDHi+uXikPCudOoBnEHi7i1viB0suYx0HV74fky3BPLOkZk9W/ 7falOI482hQR/ThGOzv780D6hGFWVSpIV2QSfgz85HkGS2KLnbTtX6UFIiNfGBtvUqVb P4EA== X-Gm-Message-State: APjAAAUCOopbG1Oewn3nhbBDPoPdx0R+KbwpYOPOx1YYplz6j8T5uMtn MPIVTqRQN9Gx6OY5Av4HmNy1nxvn X-Google-Smtp-Source: APXvYqy8ugPd8ikyuquarwFQo2BXHQRrk62sKJCnxFohCR/ZmF6tsAdhIHyYmq4Xo14zQ/hZMtcaUw== X-Received: by 2002:a5d:9f50:: with SMTP id u16mr4846113iot.110.1567003704893; Wed, 28 Aug 2019 07:48:24 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id s11sm2393577ioo.45.2019.08.28.07.48.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 07:48:23 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Wed, 28 Aug 2019 15:15:46 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166008 Archived-At: Stefan Kangas writes: > package-autoload-ensure-default-file now uses autoload-rubric internally > and no longer contains the line quoted above with "no-byte-compile". > However, autoload-rubric still contains it. > > I guess the question is if it's there for good reason or could perhaps > be omitted. If there's a good reason for it, perhaps this bug should be > closed as wontfix. > > Noam, I noted that you added a comment to this particular line recently > in commit 1f7b602f84. Could you perhaps shed some light on why we use > no-byte-compile here? As the comment says "#$ is byte-compiled into nil", and we use #$ in the generated autoloaded file. So byte-compiling would break it. I think it would work to use load-file-name instead.