* bug#69493: 30.0.50; Preferable choice of coding system on Japanese
@ 2024-03-01 23:44 Kazuhiro Ito
2024-03-02 7:07 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Kazuhiro Ito @ 2024-03-01 23:44 UTC (permalink / raw
To: 69493
When I call (set-language-environment "Japanese"), below code in
lisp/language/japan-util.el is called.
(defun setup-japanese-environment-internal ()
(prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
'japanese-shift-jis
'utf-8))
(use-cjk-char-width-table 'ja_JP))
1. japanese-shift-jis is not proper coding system on Cygwin.
2. We have japanese-cp932, more appropriate coding system for DOS/Windows.
PLease see below patch.
diff --git a/lisp/language/japan-util.el b/lisp/language/japan-util.el
index 93e8ab24971..f3ec44bf75d 100644
--- a/lisp/language/japan-util.el
+++ b/lisp/language/japan-util.el
@@ -29,8 +29,8 @@
;;;###autoload
(defun setup-japanese-environment-internal ()
- (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
- 'japanese-shift-jis
+ (prefer-coding-system (if (memq system-type '(windows-nt ms-dos))
+ 'japanese-cp932
'utf-8))
(use-cjk-char-width-table 'ja_JP))
--
Kazuhiro Ito
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#69493: 30.0.50; Preferable choice of coding system on Japanese
2024-03-01 23:44 bug#69493: 30.0.50; Preferable choice of coding system on Japanese Kazuhiro Ito
@ 2024-03-02 7:07 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2024-03-02 7:07 UTC (permalink / raw
To: Kazuhiro Ito; +Cc: 69493-done
> Date: Sat, 02 Mar 2024 08:44:56 +0900
> From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
>
> When I call (set-language-environment "Japanese"), below code in
> lisp/language/japan-util.el is called.
>
> (defun setup-japanese-environment-internal ()
> (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
> 'japanese-shift-jis
> 'utf-8))
> (use-cjk-char-width-table 'ja_JP))
>
> 1. japanese-shift-jis is not proper coding system on Cygwin.
> 2. We have japanese-cp932, more appropriate coding system for DOS/Windows.
>
> PLease see below patch.
Thanks, installed on the master branch, and closing the bug.
P.S. Please in the future try to submit patches in the format produced
by "git format-patch" -- that makes applying the patches much easier.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-02 7:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-01 23:44 bug#69493: 30.0.50; Preferable choice of coding system on Japanese Kazuhiro Ito
2024-03-02 7:07 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.