From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Fixes to let woman.el deal with MANPATH_MAP elements Date: Fri, 23 Mar 2007 21:03:16 +0100 Message-ID: <85wt1720e3.fsf@lola.goethe.zz> References: <85tzwc2qyi.fsf@lola.goethe.zz> <853b3v3j2f.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1174680213 26156 80.91.229.12 (23 Mar 2007 20:03:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2007 20:03:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 23 21:03:30 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HUpyz-0002Ry-1b for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 21:03:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUq0u-0004H5-Ri for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 15:05:28 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HUq0r-0004Gg-3x for emacs-devel@gnu.org; Fri, 23 Mar 2007 16:05:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HUq0p-0004GT-VN for emacs-devel@gnu.org; Fri, 23 Mar 2007 16:05:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUq0p-0004GQ-MM for emacs-devel@gnu.org; Fri, 23 Mar 2007 15:05:23 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HUpyt-0006g0-2i for emacs-devel@gnu.org; Fri, 23 Mar 2007 16:03:23 -0400 Original-Received: from [127.0.0.1] (helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HUpwt-0006eH-EL; Fri, 23 Mar 2007 16:01:19 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id CAC0B1C4F93F; Fri, 23 Mar 2007 21:03:16 +0100 (CET) In-Reply-To: <853b3v3j2f.fsf@lola.goethe.zz> (David Kastrup's message of "Fri\, 23 Mar 2007 19\:34\:32 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68430 Archived-At: David Kastrup writes: > Eli Zaretskii writes: > >>> From: David Kastrup >>> Date: Fri, 23 Mar 2007 11:29:25 +0100 >>> >>> Both problems appear fixed with the following rather straightforward >>> patch. While it clearly fixes faulty behavior, it could be considered >>> bordering on "new feature". >>> >>> Should I still apply it? >> >> That's something for Richard to decide. >> >>> ! (unless path (setq path (split-string (getenv "PATH") ":" t))) >> >> Please don't install such unportable code: only Posix platforms use >> `:' to separate directories in PATH and other similar variables. >> Please use `path-separator' instead. > > Thanks, that was important information. It would not have broken > previously existing behavior, but would not have helped, either. I'll > rework the patch. Eli? I am utterly befuddled by the code in woman.el. Should I be using "parse-colon-path" or "woman-parse-colon-path" here? It is not clear to me whether "PATH" is covered by the same special rules that either one of the above functions would use. As the code appears to be cowritten by you, could you suggest what to use instead of (split-string (getenv "PATH") ":" t) here? Should I use one of the above-mentioned functions, or just (split-string (getenv "PATH") path-separator t)? Thanks, -- David Kastrup, Kriemhildstr. 15, 44793 Bochum