From: David Kastrup <dak@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Fixes to let woman.el deal with MANPATH_MAP elements
Date: Fri, 23 Mar 2007 21:03:16 +0100 [thread overview]
Message-ID: <85wt1720e3.fsf@lola.goethe.zz> (raw)
In-Reply-To: <853b3v3j2f.fsf@lola.goethe.zz> (David Kastrup's message of "Fri\, 23 Mar 2007 19\:34\:32 +0100")
David Kastrup <dak@gnu.org> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: David Kastrup <dak@gnu.org>
>>> Date: Fri, 23 Mar 2007 11:29:25 +0100
>>>
>>> Both problems appear fixed with the following rather straightforward
>>> patch. While it clearly fixes faulty behavior, it could be considered
>>> bordering on "new feature".
>>>
>>> Should I still apply it?
>>
>> That's something for Richard to decide.
>>
>>> ! (unless path (setq path (split-string (getenv "PATH") ":" t)))
>>
>> Please don't install such unportable code: only Posix platforms use
>> `:' to separate directories in PATH and other similar variables.
>> Please use `path-separator' instead.
>
> Thanks, that was important information. It would not have broken
> previously existing behavior, but would not have helped, either. I'll
> rework the patch.
Eli?
I am utterly befuddled by the code in woman.el. Should I be using
"parse-colon-path" or "woman-parse-colon-path" here?
It is not clear to me whether "PATH" is covered by the same special
rules that either one of the above functions would use.
As the code appears to be cowritten by you, could you suggest what to
use instead of
(split-string (getenv "PATH") ":" t)
here? Should I use one of the above-mentioned functions, or just
(split-string (getenv "PATH") path-separator t)?
Thanks,
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-03-23 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 10:29 Fixes to let woman.el deal with MANPATH_MAP elements David Kastrup
2007-03-23 14:16 ` Eli Zaretskii
2007-03-23 18:34 ` David Kastrup
2007-03-23 20:03 ` David Kastrup [this message]
2007-03-23 20:12 ` Drew Adams
2007-03-23 20:25 ` David Kastrup
2007-03-23 21:09 ` David Kastrup
2007-03-23 18:00 ` Richard Stallman
2007-03-24 15:09 ` David Kastrup
2007-03-24 16:57 ` Eli Zaretskii
2007-03-24 17:07 ` David Kastrup
2007-03-24 17:39 ` Eli Zaretskii
2007-03-31 15:25 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85wt1720e3.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.