From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: npostavs@gmail.com Newsgroups: gmane.emacs.bugs Subject: bug#26242: 25.1; `dired-shrink-to-fit' warning Date: Wed, 12 Jun 2019 11:48:35 -0400 Message-ID: <85tvcuajos.fsf@gmail.com> References: <0159673c-b125-422a-b192-09e16132afa9@default> <87imtavo2j.fsf@mouse.gnus.org> <21a73189-b234-410a-b93d-07129bfed981@default> <85wohqakdi.fsf@gmail.com> <81f3c127-0080-49c4-8f17-c78cfc022570@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="156301"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) Cc: Lars Ingebrigtsen , 26242@debbugs.gnu.org, npostavs@gmail.com To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 12 17:50:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hb5Vg-000eWX-Dk for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 17:50:00 +0200 Original-Received: from localhost ([::1]:33288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb5Vf-0004zH-GD for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 11:49:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43058) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb5Ul-0004NL-Vm for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 11:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hb5Uk-0004UX-QU for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 11:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hb5Uk-0004Tq-BV for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 11:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hb5Uk-0003Br-7Z for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 11:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 26242-submit@debbugs.gnu.org id=B26242.156035452312234 (code B ref 26242); Wed, 12 Jun 2019 15:49:02 +0000 Original-Received: (at 26242) by debbugs.gnu.org; 12 Jun 2019 15:48:43 +0000 Original-Received: from localhost ([127.0.0.1]:33929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5UR-0003BG-F1 for submit@debbugs.gnu.org; Wed, 12 Jun 2019 11:48:43 -0400 Original-Received: from mail-io1-f51.google.com ([209.85.166.51]:42112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb5UP-0003Az-Q9 for 26242@debbugs.gnu.org; Wed, 12 Jun 2019 11:48:42 -0400 Original-Received: by mail-io1-f51.google.com with SMTP id u19so13329845ior.9 for <26242@debbugs.gnu.org>; Wed, 12 Jun 2019 08:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=X+oXPfWw4e7LGZO6GUfCuB3BYeh01Mmhhfk9gQzjucg=; b=mb3d1bE6Xmpt1LJL9A6gxEvz1MAKskfdkvu7hlJ3GMJNI5boARINWH4Ct7FvUK8lF/ Zori5u/qkPnxO6AYYsT2Vs5LqGbUSkiMER3leMqtpXWTT2tHLjwr3HxnSkecPfwW9Izr 0tUZFDF7XN47bREzay2HBvqY6hh4l7PTxPz8oIx0CUrqd0k9mbNpNWzk3ipXdvJLF2ir 5Ogt8QzmSsGmQH3ptORQ9Mddwo9okkksJQpJ0fooRPkwDhTop3cHwJR8hjv191CtTOc6 fxrpRyUl525jFkyFghLEvcjiFtEZE4dmNs6hWca/OZAFlNyu95AqcYvfNs/75K8XBFl7 HJAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=X+oXPfWw4e7LGZO6GUfCuB3BYeh01Mmhhfk9gQzjucg=; b=QzQoSM1x0yO9ecBBrrO/zB96DfK+nyVen4nZ/urqFKF6vHYUo4LRJSupkzkIHLRSqz RM5mb989CUlC6JmvJmwwGuorf2h2rBF2vexMHsZZmyaoL76Jow3eIIz9kahYMNbggqsc 64CklYJxYMyfHkvfG85Y2ZjqEDXMNwjQ+x1Vep8+1IVf3VzOhy1bn1Tnz9nZOV7agvfN DPvxspkdA0K2vJ8T0P/KpE/WJzNqSdq4JVo2GeaVYZdJp6SDAwyGQ9G/y03S0SevCos7 EuHbZATadZ8gL4hPAyD4XdomDt1ORjaRnhiHig7SkoQB0VGxPaIAn0RvH2dBfA/8MuBu Vucg== X-Gm-Message-State: APjAAAVsyletWnqd9KQPlEkpGyLEHRvyd4D8RFs4dAWHoYWzOkSsDmna wOnZglgjvR7qcfQAUtevHB9QsP26 X-Google-Smtp-Source: APXvYqwZmB46IhAJ9WIqZdYp58nUDmB1onexFd+C2Vkx62ymYkqeCk82hxDXxLNFSsJFrhWhy2AuIQ== X-Received: by 2002:a6b:7109:: with SMTP id q9mr8930285iog.30.1560354515857; Wed, 12 Jun 2019 08:48:35 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id m68sm124371itm.1.2019.06.12.08.48.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 08:48:35 -0700 (PDT) In-Reply-To: <81f3c127-0080-49c4-8f17-c78cfc022570@default> (Drew Adams's message of "Wed, 12 Jun 2019 08:40:56 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160450 Archived-At: Drew Adams writes: > Don't issue that byte-compiler warning, but > instead do one or more of the things I suggested. > What we should do is just restore the definition of > `dired-shrink-to-fit' (perhaps even making it a constant with value > `t'), or just replace occurrences of it with `t' and declare it obsolete > but without such a silly warning that tells you to customize > `display-buffer-alist'. So something like this (I don't see the benefit of replacing occurrences with `t' before actually removing it completely)? --- i/lisp/dired.el +++ w/lisp/dired.el @@ -299,9 +299,7 @@ dired-shrink-to-fit ;; (> baud-rate search-slow-speed) "Non-nil means Dired shrinks the display buffer to fit the marked files.") (make-obsolete-variable 'dired-shrink-to-fit - "use the Customization interface to add a new rule -to `display-buffer-alist' where condition regexp is \"^ \\*Marked Files\\*$\", -action argument symbol is `window-height' and its value is nil." "24.3") + "stop using it." "24.3") (defvar dired-file-version-alist)