From: npostavs@gmail.com
To: Drew Adams <drew.adams@oracle.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
26242@debbugs.gnu.org, npostavs@gmail.com
Subject: bug#26242: 25.1; `dired-shrink-to-fit' warning
Date: Wed, 12 Jun 2019 11:48:35 -0400 [thread overview]
Message-ID: <85tvcuajos.fsf@gmail.com> (raw)
In-Reply-To: <81f3c127-0080-49c4-8f17-c78cfc022570@default> (Drew Adams's message of "Wed, 12 Jun 2019 08:40:56 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> Don't issue that byte-compiler warning, but
> instead do one or more of the things I suggested.
> What we should do is just restore the definition of
> `dired-shrink-to-fit' (perhaps even making it a constant with value
> `t'), or just replace occurrences of it with `t' and declare it obsolete
> but without such a silly warning that tells you to customize
> `display-buffer-alist'.
So something like this (I don't see the benefit of replacing occurrences
with `t' before actually removing it completely)?
--- i/lisp/dired.el
+++ w/lisp/dired.el
@@ -299,9 +299,7 @@ dired-shrink-to-fit
;; (> baud-rate search-slow-speed)
"Non-nil means Dired shrinks the display buffer to fit the marked files.")
(make-obsolete-variable 'dired-shrink-to-fit
- "use the Customization interface to add a new rule
-to `display-buffer-alist' where condition regexp is \"^ \\*Marked Files\\*$\",
-action argument symbol is `window-height' and its value is nil." "24.3")
+ "stop using it." "24.3")
(defvar dired-file-version-alist)
next prev parent reply other threads:[~2019-06-12 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 18:09 bug#26242: 25.1; `dired-shrink-to-fit' warning Drew Adams
2019-06-12 15:08 ` Lars Ingebrigtsen
2019-06-12 15:22 ` Drew Adams
2019-06-12 15:33 ` npostavs
2019-06-12 15:40 ` Drew Adams
2019-06-12 15:48 ` npostavs [this message]
2019-06-12 16:16 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85tvcuajos.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=26242@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.