bug#26242: 25.1; `dired-shrink-to-fit' warning

[npostavs@gmail.com]

Drew Adams <drew.adams@oracle.com> writes:

> Don't issue that byte-compiler warning, but
> instead do one or more of the things I suggested.

> What we should do is just restore the definition of
> `dired-shrink-to-fit' (perhaps even making it a constant with value
> `t'), or just replace occurrences of it with `t' and declare it obsolete
> but without such a silly warning that tells you to customize
> `display-buffer-alist'.

So something like this (I don't see the benefit of replacing occurrences
with `t' before actually removing it completely)?

--- i/lisp/dired.el
+++ w/lisp/dired.el
@@ -299,9 +299,7 @@ dired-shrink-to-fit
 ;;  (> baud-rate search-slow-speed)
   "Non-nil means Dired shrinks the display buffer to fit the marked files.")
 (make-obsolete-variable 'dired-shrink-to-fit
-			"use the Customization interface to add a new rule
-to `display-buffer-alist' where condition regexp is \"^ \\*Marked Files\\*$\",
-action argument symbol is `window-height' and its value is nil." "24.3")
+			"stop using it." "24.3")
 
 (defvar dired-file-version-alist)