From: David Kastrup <dak@gnu.org>
To: Dave Goel <deego3@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>, Jason Rumney <jasonr@gnu.org>,
Richard Stallman <rms@gnu.org>,
emacs-devel@gnu.org
Subject: Re: Fixing numerous `message' bugs..
Date: Tue, 11 Dec 2007 00:02:14 +0100 [thread overview]
Message-ID: <85sl2am9vt.fsf@lola.goethe.zz> (raw)
In-Reply-To: <87mysirwyr.fsf@marie.gnufans.net> (Dave Goel's message of "Mon, 10 Dec 2007 17:44:44 -0500")
Dave Goel <deego3@gmail.com> writes:
>> (message "%s" (or x ""))
>>
>> will work instead of the proposed (message t x)
>
> (a) This looks like a neat "trick", but is confusing code. Code
> should be readable and as manifest as possible, and not rely on such
> "hidden" tricks. On the obfuscation scale, this is far worse than
> something as innocuous as (or foo (error bar)), and note that some
> authors even oppose that..
>
> (b) This code also relies on an undocumented feature of `message' - that
> "" as the first argument makes it behave almost the same as if the
> argument were nil.
Undocumented?
If the first argument is nil or the empty string, the function clears
any existing message; this lets the minibuffer contents show. See
also `current-message'.
It is not the first argument, though, that is "" here.
> (c) Also note that (message "") is not exactly the same as (message
> nil), because they return different values.
>
>> and considering that it rarely occurs (I think I should have got
>> most cases),
>
> Most, but not all.
Which one is missing? Note that you still have to hunt all of them
down.
>> I don't think it is really worth the trouble.
>
> Hm, but where is the trouble? This is a backward-compatible change.
But it is a surprising one, inconsistent with `format'.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-12-10 23:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 0:14 Fixing numerous `message' bugs D. Goel
2007-12-06 10:56 ` David Kastrup
2007-12-06 14:36 ` Dave Goel
2007-12-06 19:26 ` Glenn Morris
2007-12-06 19:34 ` Dave Goel
2007-12-06 20:21 ` Johan Bockgård
2007-12-07 5:28 ` Glenn Morris
2007-12-07 15:52 ` Dave Goel
2007-12-06 15:53 ` Stefan Monnier
2007-12-06 16:01 ` Dave Goel
2007-12-06 16:49 ` Stefan Monnier
2007-12-06 16:58 ` David Kastrup
2007-12-06 17:19 ` David Kastrup
2007-12-07 17:17 ` Richard Stallman
2007-12-07 17:37 ` David Kastrup
2007-12-07 17:17 ` Richard Stallman
2007-12-07 17:18 ` Richard Stallman
2007-12-07 17:24 ` David Kastrup
2007-12-07 18:00 ` Dave Goel
2007-12-07 18:38 ` Stefan Monnier
2007-12-08 0:56 ` Glenn Morris
2007-12-08 2:21 ` Stefan Monnier
2007-12-08 10:55 ` David Kastrup
2007-12-08 19:15 ` Richard Stallman
2007-12-10 17:41 ` Dave Goel
2007-12-10 18:04 ` Jason Rumney
2007-12-10 19:05 ` Dave Goel
2007-12-10 19:56 ` Andreas Schwab
2007-12-10 20:31 ` Dave Goel
2007-12-10 21:19 ` David Kastrup
2007-12-10 22:44 ` Dave Goel
2007-12-10 23:02 ` David Kastrup [this message]
2007-12-08 19:15 ` Richard Stallman
2007-12-07 17:18 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85sl2am9vt.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=deego3@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
--cc=rms@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.