From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: C-g crash redux Date: Sat, 05 Aug 2006 07:45:41 +0200 Message-ID: <85r6zvag6y.fsf@lola.goethe.zz> References: <877j1qvp4k.fsf@pacem.orebokech.com> <17617.8764.824445.882539@kahikatea.snap.net.nz> <87fygd97j0.fsf@stupidchicken.com> <87zmelfihg.fsf@stupidchicken.com> <877j1owmhx.fsf@stupidchicken.com> <874pwsebes.fsf@stupidchicken.com> <17619.50473.875843.483875@kahikatea.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1154854975 8763 80.91.229.2 (6 Aug 2006 09:02:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 6 Aug 2006 09:02:55 +0000 (UTC) Cc: Nick Roberts , Romain Francoise , Chong Yidong , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 06 11:02:53 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G9eX7-0007IE-2T for ged-emacs-devel@m.gmane.org; Sun, 06 Aug 2006 11:02:53 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G9eX6-0000gE-HL for ged-emacs-devel@m.gmane.org; Sun, 06 Aug 2006 05:02:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G9eWk-0000fB-HN for emacs-devel@gnu.org; Sun, 06 Aug 2006 05:02:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G9eWj-0000dk-25 for emacs-devel@gnu.org; Sun, 06 Aug 2006 05:02:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G9eWi-0000da-MO for emacs-devel@gnu.org; Sun, 06 Aug 2006 05:02:28 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G9eah-0006lb-4o for emacs-devel@gnu.org; Sun, 06 Aug 2006 05:06:35 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1G9eWg-0007B0-79; Sun, 06 Aug 2006 05:02:26 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 613011C4CE1A; Sat, 5 Aug 2006 07:45:42 +0200 (CEST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Sat, 05 Aug 2006 01:35:03 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58143 Archived-At: storm@cua.dk (Kim F. Storm) writes: > Nick Roberts writes: > >> > The previous code suggestion I gave was not well thought out. The >> > correct way to implement this is as follows. I've checked that with >> > this change, the addition of wait_reading_process_output_unwind does >> > not cause a crash when C-g is done during sit-for. >> > >> > Do you think this is the right approach? > > Clever! Yes. > > >> >... >> >> It looks good to my inexperienced eye, but Emacs seems to go for a long time >> before hitting Fsignal. I wonder if Fsignal resets other things that might not >> add up in the interim period but I don't know what the rules are for placing >> the QUIT macro or whether one could be placed closer to read_char. > > I don't follow this argument. > > Since the purpose of setting waiting_for_input is for emacs to produce > C-g, it depends on the key binding whether Fsignal is ever called. There is no situation on a tty or on any platform where this is done by signal directly? And it does not depend on SYNC_INPUT? While I have no clue about the situation, those are two keywords that pop up in my head. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum