From: Noam Postavsky <npostavs@gmail.com>
To: Sebastian Fieber <sebastian.fieber@web.de>
Cc: 40397@debbugs.gnu.org
Subject: bug#40397: 28.0.50; epg decrypt does not verify signed content in smime
Date: Mon, 06 Apr 2020 12:32:29 -0400 [thread overview]
Message-ID: <85r1x0mv6q.fsf@gmail.com> (raw)
In-Reply-To: <87wo6tayhy.fsf@web.de> (Sebastian Fieber's message of "Mon, 06 Apr 2020 09:01:45 +0200")
Sebastian Fieber <sebastian.fieber@web.de> writes:
> On So, Apr 05 2020, Noam Postavsky <npostavs@gmail.com> wrote:
>
>> Sebastian Fieber <sebastian.fieber@web.de> writes:
>>
>>> - (while (search-forward "\r\n" nil t)
>>> + (while (search-forward-regexp "\r\n|\^M\n" nil t)
>>
>> This can't be right, it would search for a literal "|" on an otherwise
>> empty line. And if you put "\\|" which is what I think you meant, then
>> both alternatives would be the same, so it still doesn't make sense.
>
> Yes, and there is another problem with this. Should have tested this mit
> emacs -Q. Let me fix that and prepare a new patch.
This hunk looks a bit suspicious to me as well, I don't think you can
apply operators like "?" to anchors.
@@ -759,7 +782,7 @@ MIME-Version header before proceeding."
(mb enable-multibyte-characters)
beg)
(goto-char (point-min))
- (search-forward-regexp "^\n" nil 'move) ;; There might be no body.
+ (search-forward-regexp "^?\n" nil 'move) ;; There might be no body.
(setq beg (point))
(with-current-buffer
(generate-new-buffer " *mm*")
> Since you have looked over the patch: What do you think about the
> approach to internally structure application/pkcs7-mime parts like
> multipart parts containing the mime type with text properties until the
> decrypted, maybe verified singlepart in the car of the handle?
Sorry, I'm not familiar enough with how this code is currently
structured to say anything intelligent about that.
next prev parent reply other threads:[~2020-04-06 16:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 23:37 bug#40397: 28.0.50; epg decrypt does not verify signed content in smime encrypted and signed message Sebastian Fieber
2020-04-03 6:47 ` bug#40397: 28.0.50; epg decrypt does not verify signed content in smime Sebastian Fieber
2020-04-03 23:22 ` Sebastian Fieber
2020-04-05 0:37 ` Sebastian Fieber
2020-04-06 0:04 ` Sebastian Fieber
2020-04-06 1:17 ` Noam Postavsky
2020-04-06 7:01 ` Sebastian Fieber
2020-04-06 16:32 ` Noam Postavsky [this message]
2020-04-07 19:22 ` Sebastian Fieber
2020-04-19 12:16 ` Noam Postavsky
2020-08-02 6:02 ` Lars Ingebrigtsen
2020-08-02 20:11 ` Sebastian Fieber
2020-08-03 2:26 ` Eli Zaretskii
2020-08-03 6:06 ` Lars Ingebrigtsen
2021-07-21 15:41 ` bug#40397: 28.0.50; epg decrypt does not verify signed content in smime encrypted and signed message Lars Ingebrigtsen
2021-07-21 18:07 ` Sebastian Fieber
2021-07-21 22:02 ` Lars Ingebrigtsen
2021-12-21 19:39 ` Sebastian Fieber
2021-12-22 12:44 ` Lars Ingebrigtsen
2021-12-23 18:14 ` Sebastian Fieber
2021-12-23 18:17 ` Sebastian Fieber
2021-12-23 18:25 ` Sebastian Fieber
2021-12-23 21:06 ` Sebastian Fieber
2021-12-24 9:44 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85r1x0mv6q.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=40397@debbugs.gnu.org \
--cc=sebastian.fieber@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.