From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: Your commit 7409a79 Date: Sat, 06 Dec 2014 16:43:34 -0600 Message-ID: <85oargflgp.fsf@stephe-leake.org> References: <83h9x917il.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417905849 14393 80.91.229.3 (6 Dec 2014 22:44:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Dec 2014 22:44:09 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 06 23:44:04 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XxO55-0005hJ-5Y for ged-emacs-devel@m.gmane.org; Sat, 06 Dec 2014 23:44:03 +0100 Original-Received: from localhost ([::1]:55814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxO54-00065f-Kc for ged-emacs-devel@m.gmane.org; Sat, 06 Dec 2014 17:44:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxO4l-00064Z-Pf for emacs-devel@gnu.org; Sat, 06 Dec 2014 17:43:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XxO4g-0006fA-6l for emacs-devel@gnu.org; Sat, 06 Dec 2014 17:43:43 -0500 Original-Received: from dnvrco-outbound-snat.email.rr.com ([107.14.73.231]:60151 helo=dnvrco-oedge-vip.email.rr.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxO4g-0006f6-21 for emacs-devel@gnu.org; Sat, 06 Dec 2014 17:43:38 -0500 Original-Received: from [70.94.38.149] ([70.94.38.149:52881] helo=TAKVER) by dnvrco-oedge02 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id B3/A2-05421-99683845; Sat, 06 Dec 2014 22:43:37 +0000 In-Reply-To: (Tom's message of "Sat, 6 Dec 2014 16:14:42 +0000 (UTC)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.94 (windows-nt) X-RR-Connecting-IP: 107.14.64.130:25 X-Authority-Analysis: v=2.1 cv=NtdfcqtJ c=1 sm=1 tr=0 a=AppmJ/7ZOOFWL/q6u6u93g==:117 a=AppmJ/7ZOOFWL/q6u6u93g==:17 a=ayC55rCoAAAA:8 a=fNEgcOh0sVsA:10 a=9i_RQKNPAAAA:8 a=pGLkceISAAAA:8 a=mDV3o1hIAAAA:8 a=WdyzDcSA_iYwuvd1G48A:9 a=2fcrIxHVTVsA:10 X-Cloudmark-Score: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 107.14.73.231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179220 Archived-At: Tom writes: > Eli Zaretskii gnu.org> writes: >> >> Please always start the commit log summary line with a capital letter, >> and end the sentence with a period. (Actually, in the above >> particular case the summary line is redundant and could be omitted -- >> but this is a stylistic comment, not a requirement.) >> >> Also, renaming a file needs an entry in the target's ChangeLog, like >> this: >> >> * CONTRIBUTE: Renamed from etc/CONTRIBUTE. >> >> and it also should end with a period, not a comma. >> > > These are exactly the situations where a server side commit hook > is really useful for the following reasons: > > 1. It prevent commits with incorrectly formatted commit messages. To be precise, if it's only running on the server (Savannah), it does not prevent the _commit_, it prevents the _push_. There are a couple commit hooks in emacs/.git/hooks set by autogen.sh (amazing what you learn reading commit logs :); we could add a hook there to do this check. vc could check for proper formatting before doing the commit. Catching errors as early as possible is always better. Of course, it would be even better if vc would silently fix the formatting. > 2. It prints an error message describing the problem, thereby > teaching the committer how to make a properly formatted commit. > > So there is no need for manually replying to incorrect commits > on the list, because the script checks every commit and even > tells the user the problem. > > So it would be a good idea to add such a precommit script to the > server. If we go this route, let's also add some vc functionality that checks and/or does the formatting, and make sure the commit error message mentions both CONTRIBUTE and the vc function. -- -- Stephe