From: Wolfgang Jenkner <wjenkner@inode.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20783-done@debbugs.gnu.org
Subject: bug#20783: 25.0.50; [PATCH] byte-to-position has internal off-by-one bug
Date: Wed, 17 Jun 2015 14:19:10 +0200 [thread overview]
Message-ID: <85oakemsbc.fsf@iznogoud.viz> (raw)
In-Reply-To: <85fv5za8vv.fsf@iznogoud.viz>
Version: 25.1
On Thu, Jun 11 2015, Eli Zaretskii wrote:
> Works for me, thanks. But please add a comment there about
> BYTE_TO_CHAR expecting byte positions that are on a character
> boundary, so that the reason for the loop is clear.
Done and pushed.
However, I didn't follow my own suggestion of adding a remark to the
comment above BYTE_TO_CHAR, after all, as it is true for most macros or
functions with a byte position argument, so adding such a comment to
just one of them could be confusing, I think.
Thank you for steering this change in the right direction.
next prev parent reply other threads:[~2015-06-17 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 15:13 bug#20783: 25.0.50; [PATCH] byte-to-position has internal off-by-one bug Wolfgang Jenkner
2015-06-10 17:17 ` Eli Zaretskii
2015-06-11 15:24 ` Wolfgang Jenkner
2015-06-11 16:04 ` Eli Zaretskii
2015-06-11 16:41 ` Wolfgang Jenkner
2015-06-11 19:08 ` Eli Zaretskii
2015-06-17 12:19 ` Wolfgang Jenkner [this message]
2015-06-17 16:57 ` Eli Zaretskii
2015-06-16 15:40 ` Wolfgang Jenkner
2015-06-16 16:08 ` Eli Zaretskii
2015-06-16 16:31 ` Wolfgang Jenkner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85oakemsbc.fsf@iznogoud.viz \
--to=wjenkner@inode.at \
--cc=20783-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.