From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: =?UTF-8?Q?Symbol=E2=80=99s?= value as variable is void: image-map Date: Thu, 11 Feb 2016 16:29:16 +0100 Message-ID: <85oabnl0w8.fsf@iznogoud.viz> References: <868u2s1ydw.fsf@boetes.org> <85lh6so6p5.fsf@iznogoud.viz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455204803 4091 80.91.229.3 (11 Feb 2016 15:33:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Feb 2016 15:33:23 +0000 (UTC) Cc: Lars Ingebrigtsen , han@boetes.org, 22614@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 11 16:33:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aTtF1-00029o-NV for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Feb 2016 16:33:11 +0100 Original-Received: from localhost ([::1]:51019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtF1-0001EE-46 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Feb 2016 10:33:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtEx-0001E0-2I for bug-gnu-emacs@gnu.org; Thu, 11 Feb 2016 10:33:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTtEs-0000rg-3B for bug-gnu-emacs@gnu.org; Thu, 11 Feb 2016 10:33:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtEr-0000rc-VD for bug-gnu-emacs@gnu.org; Thu, 11 Feb 2016 10:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aTtEr-0001Xq-P6 for bug-gnu-emacs@gnu.org; Thu, 11 Feb 2016 10:33:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <868u2s1ydw.fsf@boetes.org> Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Feb 2016 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22614 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22614-submit@debbugs.gnu.org id=B22614.14552047345867 (code B ref 22614); Thu, 11 Feb 2016 15:33:01 +0000 Original-Received: (at 22614) by debbugs.gnu.org; 11 Feb 2016 15:32:14 +0000 Original-Received: from localhost ([127.0.0.1]:36861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTtE6-0001WY-2H for submit@debbugs.gnu.org; Thu, 11 Feb 2016 10:32:14 -0500 Original-Received: from b2bfep16.mx.upcmail.net ([62.179.121.61]:59824) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTtE4-0001WG-3L for 22614@debbugs.gnu.org; Thu, 11 Feb 2016 10:32:12 -0500 Original-Received: from edge11.upcmail.net ([192.168.13.81]) by b2bfep16.mx.upcmail.net (InterMail vM.8.01.05.18 201-2260-151-151-20140610) with ESMTP id <20160211153204.NEWT5368.b2bfep16-int.chello.at@edge11.upcmail.net> for <22614@debbugs.gnu.org>; Thu, 11 Feb 2016 16:32:04 +0100 Original-Received: from iznogoud.viz ([91.119.83.35]) by edge11.upcmail.net with edge id H3X41s00L0ljrGj0B3X4o9; Thu, 11 Feb 2016 16:31:04 +0100 X-SourceIP: 91.119.83.35 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1aTtCx-0000Ku-Qt; Thu, 11 Feb 2016 16:31:03 +0100 User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112894 Archived-At: On Wed, Feb 10 2016, Glenn Morris wrote: > Wolfgang Jenkner wrote: > >> --- a/lisp/net/shr.el >> +++ b/lisp/net/shr.el >> @@ -189,6 +189,8 @@ shr-map >> (define-key map "\r" 'shr-browse-url) >> map)) >> >> +(defvar image-map nil) ;in case image.el is not pre-loaded >> + > > This (ie, defining something from image.el in shr.el just to stop a void > variable error) seems sub-optimal to me. Can't shr use something like > "(when (featurep 'image) ...)" instead? Well, you still get `image-map' as an interned symbol and I think it's actually better to explicitly give it a nil value since the value it is given in image.el is not too useful in an emacs where image.el is not pre-loaded, i.e. compiled without graphical support (actually, it seems to be completely useless, see other messages in this bug report). Obviously, I considered your (and also Andreas') suggestion as well, I decided otherwise, but I don't care (much). Wolfgang