bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

[Wolfgang Jenkner <wjenkner@inode.at>]

On Wed, Feb 10 2016, Glenn Morris wrote:

> Wolfgang Jenkner wrote:
>
>> --- a/lisp/net/shr.el
>> +++ b/lisp/net/shr.el
>> @@ -189,6 +189,8 @@ shr-map
>>      (define-key map "\r" 'shr-browse-url)
>>      map))
>>  
>> +(defvar image-map nil)                  ;in case image.el is not pre-loaded
>> +
>
> This (ie, defining something from image.el in shr.el just to stop a void
> variable error) seems sub-optimal to me. Can't shr use something like
> "(when (featurep 'image) ...)" instead?

Well, you still get `image-map' as an interned symbol and I think it's
actually better to explicitly give it a nil value since the value it is
given in image.el is not too useful in an emacs where image.el is not
pre-loaded, i.e. compiled without graphical support (actually, it seems
to be completely useless, see other messages in this bug report).

Obviously, I considered your (and also Andreas') suggestion as well,
I decided otherwise, but I don't care (much).

Wolfgang