From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: [Jim Meyering] Re: strftime merge from Emacs Date: Sat, 07 Jun 2003 17:28:13 +0200 Sender: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Message-ID: <85n0gtoqk2.fsf@pi.meyering.net> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1054999597 12665 80.91.224.249 (7 Jun 2003 15:26:37 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 7 Jun 2003 15:26:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Sat Jun 07 17:26:35 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19OfaU-0003Hz-00 for ; Sat, 07 Jun 2003 17:26:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19Ofce-0002Mn-VM for gnu-bug-gnulib@m.gmane.org; Sat, 07 Jun 2003 11:28:48 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19OfcQ-00024g-Vz for bug-gnulib@gnu.org; Sat, 07 Jun 2003 11:28:34 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19OfcC-0001Lk-Tg for bug-gnulib@gnu.org; Sat, 07 Jun 2003 11:28:22 -0400 Original-Received: from anice-201-1-1-11.w80-13.abo.wanadoo.fr ([80.13.35.11] helo=elf.meyering.net) by monty-python.gnu.org with esmtp (Exim 4.20) id 19OfcB-0001FO-BL; Sat, 07 Jun 2003 11:28:19 -0400 Original-Received: by elf.meyering.net (Postfix, from userid 1002) id 505EC4121; Sat, 7 Jun 2003 17:28:13 +0200 (CEST) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Sat, 07 Jun 2003 06:22:42 -0400") Original-Lines: 46 Original-cc: Dave Love Original-cc: bug-gnulib@gnu.org X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: The GNUlib portability library bug discussion list List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Xref: main.gmane.org gmane.comp.lib.gnulib.bugs:455 gmane.emacs.devel:14878 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14878 Richard Stallman wrote: > > [__hpux]: Include sys/_mbstate_t.h. > > Using a macro like __hpux should be done only as a last resort. > I hope there is a better way. > > One idea is to test using Autoconf for the existence of such a file > and include it if it exists. That will work provided there is no case > where that file exists but including it is harmful. > > Does emacs still cater to compilers that don't support prototypes? > I've been removing k&r support (PROTOTYPES, __P, etc.) from the coreutils > for years without complaint. As far as emacs is concerned, is it possible > to remove such support from this file altogether? > > To remove it from strftime is tantamount to abandoning it in Emacs as > a whole. I think we should be very cautious about that. Caution is fine. However, I'm convinced that requiring a C89-compliant compiler will not bother anyone these days, and as such, I do not hesitate to remove support for K&R compilers anymore. > I haven't seen WINDOWSNT used before. > Here are some of the window-related macros I have seen: > > _WIN32 WIN32 __WIN32__ __MSDOS__ WINDOWS32 > > WINDOWSNT is what Emacs uses. It is a GNU convention that we do not > use the abbreviation "WIN" to refer to Windows. Are those names > used in any GNU packages? Yes. I found those uses in gnulib and the coreutils. BTW, is WINDOWSNT an appropriate name for such a macro? I've heard that some of the modules using those macros may be compiled on non-Windows/NT systems. In any case, I try very hard to avoid the use of such macros, and believe I know how to eliminate cleanly the one in emacs' src/strftime.c. > In any case, we try hard not to use system-dependent macros like that > and prefer to use the results of configure-time tests. > > That is preferable, but with a system as different from GNU as Windows is, > code for a specific system will tend to be needed often.