Re: emacs 25 broken?

[Stephen Leake <stephen_leake@stephe-leake.org>]

Stephen Leake <stephen_leake@stephe-leake.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Stephen Leake <stephen_leake@stephe-leake.org>
>>> Date: Tue, 24 Feb 2015 11:46:32 -0600
>>> 
>>> Whenever I try to use emacs 25, something doesn't work right, and when
>>> trying to debug it I always run into bug #19611; "e (current-buffer)" in
>>> edebug returns the wrong buffer.
>>> 
>>> Does anyone else see this problem? It's blocking all my work on master.
>>
>> Why do you need "e (current-buffer)" in Edebug so badly that it blocks
>> your work?
>
> Seriously? If I can't trust the debugger, how am I supposed to make
> progress?
>
> The real bug (in ada-mode) I'm trying to fix is in code that switches
> buffers. (That bug does not exist when the same code is run in emacs
> 24). Any expression I evaluate that relies on the current buffer is
> wrong in the debugger, so it's impossible to figure out what's going on.
>
> I did not record in the bug that `with-current-buffer' is not broken;
> executing M-x sal-debug gives the correct results.
>
> Any suggestions for further investigation?

I just noticed on the bug report that Andreas Politz isolated the commit
that broke it: commit 6194477a622ce9293162d16a7ba98c9cfc18d124 by Stefan
(I'm guessing Andreas ran git-bisect; I should have tried that).

That's a fairly small change to src/eval.c; reverting that commit does
fix bug #19611, and lets me make progress on my ada-mode bug.

I don't understand the change in eval.c, so I don't know how to fix it.

-- 
-- Stephe