From: David Kastrup <dak@gnu.org>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: diff-mode misinterprets empty lines.
Date: Fri, 30 Nov 2007 00:12:29 +0100 [thread overview]
Message-ID: <85k5o03aua.fsf@lola.goethe.zz> (raw)
In-Reply-To: <E1Ixrv5-0002TM-MN@fencepost.gnu.org> (Richard Stallman's message of "Thu, 29 Nov 2007 17:31:43 -0500")
Richard Stallman <rms@gnu.org> writes:
> When people don't want trailing whitespace warnings to trigger in their
> editor, they should obviously amend diff-mode for that. But changing
> the diff format instead is insane. And that patch happens to have
> tolerance code intended to deal with utterly broken mailers is no excuse
> for that.
>
> Are you suggesting I should ask the diff maintainers to revert that
> change? That might be a good idea.
Personally, I would consider this a good idea. The "patch" program has
apparently been made robust in the presence of mail-mangled patches,
cut&paste carnage and other damage. But "patch works with it" is, in my
opinion, not a positive definition of the diff format (while "patch
fails" is a different issue): patch is not the only program working with
diffs, and some version control systems have a diff-based workflow
without using "patch" for it.
Here is the format definition actually delivered with diff itself for
context diffs:
<URL:http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Context.html#Detailed%20Context>
And here another for unified diffs:
<URL:http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html#Detailed%20Unified>
It appears quite definite from the description that no whitespace
reduction is intended, neither for content nor for formatting
characters.
So yes, I would ask the diff maintainers to revert the change. I can't
think of a good reason for it at all, but maybe they can, so it would
probably be a good idea to keep emacs-devel in the list (after all,
Emacs is one of the applications broken by this, for now): that way we
might together reach consensus on the best course.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-11-29 23:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 1:03 diff-mode misinterprets empty lines Richard Stallman
2007-11-29 9:26 ` David Kastrup
2007-11-29 16:09 ` Stefan Monnier
2007-12-05 7:35 ` Paul Eggert
2007-12-05 10:17 ` Jim Meyering
2007-12-05 10:58 ` David Kastrup
2007-12-05 11:27 ` Jim Meyering
2007-12-05 12:33 ` Andreas Schwab
2007-12-05 12:39 ` Jim Meyering
2007-12-05 14:59 ` David Kastrup
2007-12-05 17:45 ` Paul Eggert
2007-12-05 18:12 ` David Kastrup
2007-12-06 0:54 ` Paul Eggert
2007-12-06 10:11 ` Andreas Schwab
2007-12-05 21:04 ` Juanma Barranquero
2007-12-06 15:39 ` Stefan Monnier
2008-01-06 0:15 ` Glenn Morris
2008-01-06 18:09 ` Richard Stallman
2008-01-14 21:08 ` Stefan Monnier
2008-01-14 21:38 ` Glenn Morris
2008-01-14 22:46 ` Glenn Morris
2008-01-14 23:35 ` Diffs between %s and %s end here (was: diff-mode misinterprets empty lines.) Reiner Steib
2008-01-15 3:29 ` Diffs between %s and %s end here Miles Bader
2008-01-16 8:13 ` Glenn Morris
2008-01-15 0:09 ` diff-mode misinterprets empty lines Dan Nicolaescu
2008-01-29 18:37 ` Chong Yidong
2008-02-19 16:32 ` Stefan Monnier
2008-02-19 20:44 ` Stefan Monnier
2007-12-06 2:11 ` Richard Stallman
2007-12-05 17:48 ` Paul Eggert
2007-12-05 17:50 ` Jim Meyering
2007-11-29 22:31 ` Richard Stallman
2007-11-29 23:12 ` David Kastrup [this message]
2007-11-30 2:03 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2007-11-27 18:04 Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85k5o03aua.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.