From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: npostavs@gmail.com Newsgroups: gmane.emacs.bugs Subject: bug#35368: [PATCH v3] Do potentially destructive operations in prepare-commit-msg Date: Wed, 15 May 2019 13:40:36 -0400 Message-ID: <85k1erwr8r.fsf@gmail.com> References: <87k1esg02j.fsf@gmail.com> <20190514222647.4799-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="158529"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) Cc: 35368@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 15 19:44:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQxww-000f68-7T for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 19:44:18 +0200 Original-Received: from localhost ([127.0.0.1]:40430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxwv-0004xs-4J for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2019 13:44:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxtu-000308-FS for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 13:41:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQxtq-0002nu-JP for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 13:41:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQxtm-0002jg-Fd for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 13:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQxtm-0004vJ-8L for bug-gnu-emacs@gnu.org; Wed, 15 May 2019 13:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2019 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35368-submit@debbugs.gnu.org id=B35368.155794204818897 (code B ref 35368); Wed, 15 May 2019 17:41:02 +0000 Original-Received: (at 35368) by debbugs.gnu.org; 15 May 2019 17:40:48 +0000 Original-Received: from localhost ([127.0.0.1]:53324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQxtY-0004uh-EV for submit@debbugs.gnu.org; Wed, 15 May 2019 13:40:48 -0400 Original-Received: from mail-it1-f180.google.com ([209.85.166.180]:54462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQxtT-0004uT-VJ for 35368@debbugs.gnu.org; Wed, 15 May 2019 13:40:44 -0400 Original-Received: by mail-it1-f180.google.com with SMTP id a190so1496514ite.4 for <35368@debbugs.gnu.org>; Wed, 15 May 2019 10:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9I+lC3lNwZbF5hUz6QTF09fN6BOub/goqA2BL1vKQeI=; b=biklXiBeMf/qI5+/iyAWikswU2TLRVXPDEDAAZh5/SutB1TC1fv7U4Mp3rrQCHy1W3 5tTjC+hNEFtRYl4kx0b1tVM003ci6sv0oQI6TOU//sodlOmn8p6K/URVqfi6w7liDGoj MDxapNrBLUmY/E1RwSnH8iwkc/a5D4sLAkKlGazeQo8unGS+0ks+VmRXDE8hpPEqqpiD KgBvRW8NCapVhNXEeiCeuff24v004IM2wxaV7Xjc/ju34uSWvtzG4tfE0fb8yup0qy0O QDzXnukMt+vx6P+pjVm+IqK7Kmv57T/mtDnKz30oI2P2OmcuaLOD6uORKBv+axmWG+hy fKAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9I+lC3lNwZbF5hUz6QTF09fN6BOub/goqA2BL1vKQeI=; b=dAy05Vl6AwWL8IV45HA6oNLBQ5gZT0jUfq0Roiy1A6oql6ZmUkG8EdlPjIYTFwYg24 P2ovptilUDwCzZD6gM1Nh245om28itXm8dFSYlvslzhTymCvG50Mx7AyvKnn1OlOVREs m8EBUMyxXkqyJB0CEW2hSfUIJ0aNwmRpt/RaNvMK/IlBNQss7jmEpQoiJHAfq773VLMf U3FeDDTzg/wCKvEhd1eIJ36pVEfjg6Tq9IfhRJLcqwt9NXc4012fuq5FuUmwIz344IO4 SUhuDaFI7nif0Ye1s/Te37FpjwAAwCzAoEZCL9lfbczekUHMX8rlrUrqqOgtSUEGnBeU LGOA== X-Gm-Message-State: APjAAAU99771+tEmrLTODq104GW+QQQobqsKWg1UbGRHyYw2vmrqaRki HptDwnmd7jliwD+MHVSsXqY6GKsO X-Google-Smtp-Source: APXvYqwobSGEmabkKoo7lR1W1T1KSCOQZkq9GvFTJeK790NwwUviXVSgkgLBdVNt9EPOYvFfCMQi/Q== X-Received: by 2002:a24:1dc5:: with SMTP id 188mr8856692itj.16.1557942038436; Wed, 15 May 2019 10:40:38 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id x187sm386490itb.39.2019.05.15.10.40.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 10:40:37 -0700 (PDT) In-Reply-To: <20190514222647.4799-1-Hi-Angel@yandex.ru> (Konstantin Kharlamov's message of "Wed, 15 May 2019 01:26:47 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159348 Archived-At: Konstantin Kharlamov writes: > * build-aux/git-hooks/prepare-commit-msg: if someone occasionally puts > Signed-off line, it will likely get there through -s option of git. > Exploit this fact to abort before a user got a chance to type commit > message. Thanks, looks good, but I think it would be helpful to explain that this is about catching git commit -s ... in the comments of the file too. > --- a/autogen.sh > +++ b/autogen.sh > @@ -1,4 +1,4 @@ > -#!/bin/sh > + #!/bin/sh This is a typo or something, right?