From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: local keymap patch for key-binding Date: Wed, 13 Sep 2006 00:23:13 +0200 Message-ID: <85irjs4tda.fsf@lola.goethe.zz> References: <87slj1hybl.fsf@stupidchicken.com> <85pse5cbqw.fsf@lola.goethe.zz> <87zmd7yjq4.fsf@furball.mit.edu> <85pse3n99c.fsf@lola.goethe.zz> <87r6yjxh7k.fsf@furball.mit.edu> <85venuc27c.fsf@lola.goethe.zz> <85r6yiivi7.fsf@lola.goethe.zz> <85hczdbdv2.fsf@lola.goethe.zz> <85mz959kkw.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1158099860 18593 80.91.229.2 (12 Sep 2006 22:24:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 12 Sep 2006 22:24:20 +0000 (UTC) Cc: cyd@stupidchicken.com, storm@cua.dk, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 13 00:24:18 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GNGfr-0005ab-4Q for ged-emacs-devel@m.gmane.org; Wed, 13 Sep 2006 00:24:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GNGfq-0006uR-GC for ged-emacs-devel@m.gmane.org; Tue, 12 Sep 2006 18:24:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GNGfd-0006uE-S4 for emacs-devel@gnu.org; Tue, 12 Sep 2006 18:23:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GNGfc-0006u1-KL for emacs-devel@gnu.org; Tue, 12 Sep 2006 18:23:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GNGfc-0006ty-Fu for emacs-devel@gnu.org; Tue, 12 Sep 2006 18:23:56 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GNGhC-00060O-PI for emacs-devel@gnu.org; Tue, 12 Sep 2006 18:25:34 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1GNGfU-0002zJ-Li; Tue, 12 Sep 2006 18:23:48 -0400 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 9DEB71C40B5D; Wed, 13 Sep 2006 00:23:13 +0200 (CEST) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Tue\, 12 Sep 2006 17\:45\:16 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59746 Archived-At: Richard Stallman writes: > > If you thing it reasonable that key-binding should also react to > > bona-fide events _not_ wrapped in an array, I can do this easily > > enough in the change I am working on. > > Please don't make that change. key-binding is supposed to look up a > sequence of events; it expects that sequence to be in a vector or > string. There is nothing wrong with that, and no need to change it. > > I think we simply had a misunderstanding about what it means to say > that key-binding can "look up events". In my way of looking at > things, you give key-binding a vector of events, and what it does is > "look up events." Ok, I'll rework my patch. The change I proposed concerning read-key-sequence was for the sake of letting both keymap and local-map properties (if they are specified in a string) be heeded. The current code only heeds the first of two. That puts the behavior out of line with the documentation without good reason. While this case will probably occur rarely, I see no reason not to do the correct thing as documented. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum