From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: avoiding revert-buffer after vc-checkin Date: Wed, 18 Jul 2007 23:21:56 +0200 Message-ID: <85ir8hxv9n.fsf@lola.goethe.zz> References: <200707180547.l6I5luxe002955@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1184793728 21553 80.91.229.12 (18 Jul 2007 21:22:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2007 21:22:08 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 18 23:22:06 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IBGyD-00035X-IZ for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2007 23:22:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IBGyD-0004SA-0p for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2007 17:22:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IBGy9-0004Rv-Sl for emacs-devel@gnu.org; Wed, 18 Jul 2007 17:22:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IBGy8-0004Rj-H2 for emacs-devel@gnu.org; Wed, 18 Jul 2007 17:22:00 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IBGy8-0004Rg-B0 for emacs-devel@gnu.org; Wed, 18 Jul 2007 17:22:00 -0400 Original-Received: from mail-in-05.arcor-online.net ([151.189.21.45]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IBGy7-0003ZR-VA for emacs-devel@gnu.org; Wed, 18 Jul 2007 17:22:00 -0400 Original-Received: from mail-in-12-z2.arcor-online.net (mail-in-12-z2.arcor-online.net [151.189.8.29]) by mail-in-05.arcor-online.net (Postfix) with ESMTP id 80F5812F3B9; Wed, 18 Jul 2007 23:21:58 +0200 (CEST) Original-Received: from mail-in-08.arcor-online.net (mail-in-08.arcor-online.net [151.189.21.48]) by mail-in-12-z2.arcor-online.net (Postfix) with ESMTP id 6E6BA27943A; Wed, 18 Jul 2007 23:21:58 +0200 (CEST) Original-Received: from lola.goethe.zz (dslb-084-061-086-214.pools.arcor-ip.net [84.61.86.214]) by mail-in-08.arcor-online.net (Postfix) with ESMTP id 144112D298E; Wed, 18 Jul 2007 23:21:57 +0200 (CEST) Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 837D11C3ACCF; Wed, 18 Jul 2007 23:21:56 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Wed\, 18 Jul 2007 14\:53\:32 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-Virus-Scanned: ClamAV 0.91.1/3696/Wed Jul 18 14:56:36 2007 on mail-in-08.arcor-online.net X-Virus-Status: Clean X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75098 Archived-At: Stefan Monnier writes: >> After a vc-checkin the corresponding buffer is reverted, which is not >> so convenient because the undo information is lost. > > Indeed. My own take on this problem is to change revert-buffer so that it > doesn't throw away the undo info. Revert-buffer throws away the undo info because usually after revert-buffer the undo-info is useless. > I understand that some people find this idea completely > unacceptable, so maybe a good compromise is to just provide a way to > tell revert-buffer not to throw away the undo info, and then use it > in vc.el. And how will you cater for CVS having replaced $Id: ...$ strings and similar? How do you know which offsets to apply to the undo info in order to compensate for that? -- David Kastrup, Kriemhildstr. 15, 44793 Bochum