all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kamphausen <skampi@gmx.net>
To: help-gnu-emacs@gnu.org
Subject: Re: Error with fill-paragraph in my own major mode
Date: Thu, 31 Jan 2008 09:36:59 +0100	[thread overview]
Message-ID: <85hcgutmqc.fsf@usenet.my.skamphausen.de> (raw)
In-Reply-To: jwv8x27rnn2.fsf-monnier+gnu.emacs.help@gnu.org

Hi Stefan,

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Today it has been brought to my attention that there is an error when
>> one tries to fill a paragraph (M-q) using that major mode in Gnu Emacs
>> 22.  Back then I wrote that mode in XEmacs, today I seem to be a Gnu
>> Emacs user so I'd like to fix that issue.
>
>> Hitting M-q leads to an error
>> Args out of range: "", -1, 0
>
>> Using debug-on-error and edebug I could track that error down to the
>> following code in function fill-comment-paragraph in fill.el:
>
>>   (if (string-match comment-start-skip (concat "\0" commark "a"))
>>       (concat "[ \t]*" (regexp-quote commark)
>>               ;; Make sure we only match comments that
>>               ;; use the exact same comment marker.
>>               "[^" (substring commark -1) "]")
>>                    ^^^^^^^^^^^^^^^^^^^^^^
>
> The problem is the setting of comment-start-skip.
> This regexp should match a "comment-start marker" (plus some optional
> whitespace), where you set it to "".

thanks.  I now have

 (setq comment-start "@#: "
        comment-end ""
        comment-start-skip "@#: +")


and that seems to work.  I will have to further test it, though.  The
new setting was 'inspired' by the one in texinfo-mode so I will read
some more of that code.

Nevertheless I must admit that I don't really grok that code in
fill.el.  What is that (concat "\0" commark "a") good for?

Anyway, thanks once more for your time.

Regards,
Stefan
-- 
Stefan Kamphausen --- http://www.skamphausen.de
a blessed +42 regexp of confusion (weapon in hand)
You hit. The format string crumbles and turns to dust.


  reply	other threads:[~2008-01-31  8:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 16:41 Error with fill-paragraph in my own major mode Stefan Kamphausen
2008-01-30 21:15 ` Andreas Röhler
2008-01-30 21:49 ` Stefan Monnier
2008-01-31  8:36   ` Stefan Kamphausen [this message]
2008-01-31 15:25     ` Stefan Monnier
2008-01-31 15:58       ` Stefan Kamphausen
2008-01-31 19:57         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85hcgutmqc.fsf@usenet.my.skamphausen.de \
    --to=skampi@gmx.net \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.