bug#19401: 25.0.50; metar.el (metar-convert-temperature) wrong type argument stringp nil

[Wolfgang Jenkner <wjenkner@inode.at>]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

On Tue, Jan 13 2015, Wolfgang Jenkner wrote:

> However, it's up to the author to decide if he likes this approach at
> all.

Mario,

Ping :-)  Do you mind if I push yesteryear's patch to elpa?

If you want to review it, I'll wait for your approval, of course.
Otherwise, due to popular demand, I'd like to push it in a week or so.
For easier reference, I've also attached it below.

I also proposed a second patch as a work-around for a calc glitch,
however that bug has been fixed in the last emacs release, so I think it
can be omitted.

Wolfgang


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: metar patch --]
[-- Type: text/x-diff, Size: 3816 bytes --]

From bc778d9ac011e1f27cfc85055a8575f39f912d9b Mon Sep 17 00:00:00 2001
From: Wolfgang Jenkner <wjenkner@inode.at>
Date: Sat, 3 Jan 2015 00:34:33 +0100
Subject: [PATCH 1/2] [metar] Fix the case where the metar record contains M01
 (bug#19401).

* packages/metar/metar.el (metar-convert-unit): New optional argument.
(metar-convert-temperature): Use it to rewrite this function in terms of
metar-convert-unit.
Pass t as last argument to the underlying calc conversion functions so
that they return only the number, not the unit, thereby fixing the bug
in question.
---
 packages/metar/metar.el | 66 ++++++++++++++++++++++++-------------------------
 1 file changed, 32 insertions(+), 34 deletions(-)

diff --git a/packages/metar/metar.el b/packages/metar/metar.el
index 7b78f07..9575313 100644
--- a/packages/metar/metar.el
+++ b/packages/metar/metar.el
@@ -239,45 +239,43 @@ If no match if found, nil is returned."
       (when station-code
 	(cons station-code (round best-distance))))))
 
-(defun metar-convert-unit (value new-unit)
+(defun metar-convert-unit (value new-unit &optional convert-units-function)
   "Convert VALUE to NEW-UNIT.
 VALUE is a string with the value followed by the unit, like \"5 knot\"
-and NEW-UNIT should be a unit name like \"kph\" or similar."
+and NEW-UNIT should be a unit name like \"kph\" or similar.
+CONVERT-UNITS-FUNCTION designates the function actually doing the conversion.
+It must have the signature of `math-convert-units', which is the default."
   (cl-check-type value string)
-  (cl-check-type new-unit (or string symbol))
-  (cl-multiple-value-bind (value unit)
-      (split-string
-       (math-format-value
-	(math-convert-units (math-simplify (math-read-expr value))
-			    (math-read-expr
-			     (cl-etypecase new-unit
-					   (string new-unit)
-					   (symbol (symbol-name new-unit))))))
-       " ")
-    (cons (string-to-number value) (intern unit))))
+  (unless (symbolp new-unit)
+    (setq new-unit (intern new-unit)))
+  (let ((expr (math-simplify (math-read-expr value))))
+    (cl-assert (or (math-zerop expr)
+		   (not (memq (math-single-units-in-expr-p expr) '(nil wrong))))
+	       nil
+	       "Metar: Not exactly one unit in expression: %S" expr)
+    (let ((res (math-simplify-units
+		(funcall (or convert-units-function 'math-convert-units)
+			 expr
+			 (math-build-var-name new-unit)
+			 t))))
+      (cl-assert (math-realp res) nil
+		 "Metar: Not a Calc real number: %S" res)
+      (cons (string-to-number (math-format-value (if (integerp res)
+						     res
+						   (math-float res))))
+	    new-unit))))
 
 (defun metar-convert-temperature (string &optional unit)
-  (let* ((value (concat (if (= (aref string 0) ?M)
-			    (concat "-" (substring string 1))
-			  string)
-			"degC"))
-	 (expr (math-read-expr value))
-	 (old-unit (math-single-units-in-expr-p expr))
-	 (new-unit (or unit (cdr (assq 'temperature metar-units)))))
-    (if old-unit
-	(cl-multiple-value-bind (value unit)
-	    (split-string
-	     (math-format-value
-	      (math-simplify-units
-	       (math-convert-temperature
-		expr
-		(list 'var
-		      (car old-unit)
-		      (intern (concat "var-" (symbol-name (car old-unit)))))
-		(math-read-expr (cl-etypecase new-unit
-				  (string new-unit)
-				  (symbol (symbol-name new-unit))))))) " ")
-	  (cons (string-to-number value) (intern unit))))))
+  (metar-convert-unit (concat (if (= (aref string 0) ?M)
+				  (concat "-" (substring string 1))
+				string)
+			      "degC")
+		      (or unit (cdr (assq 'temperature metar-units)))
+		      (lambda (expr new-unit-var pure)
+			(math-convert-temperature expr
+						  (math-build-var-name 'degC)
+						  new-unit-var
+						  pure))))
 
 (defcustom metar-url
   "http://weather.noaa.gov/pub/data/observations/metar/stations/%s.TXT"
-- 
2.7.0