From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#41086: Fwd: bug#41086: [PATCH] Add user-defined column widths to package-list (package.el) Date: Tue, 05 May 2020 13:24:52 -0400 Message-ID: <85ftceguqj.fsf@gmail.com> References: <87imhbo1ku.fsf@stefankangas.se> <83eerympt1.fsf@gnu.org> <83zhaml5xf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="129133"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) Cc: 41086@debbugs.gnu.org To: Chris McMahan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 05 19:26:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jW1Kc-000XTA-Tn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 19:26:10 +0200 Original-Received: from localhost ([::1]:56786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW1Kb-0002P2-R1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 13:26:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW1KU-0002Om-J0 for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 13:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jW1KU-0005yD-9i for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 13:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jW1KU-0005lE-46 for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 13:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 May 2020 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41086 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41086-submit@debbugs.gnu.org id=B41086.158869950522076 (code B ref 41086); Tue, 05 May 2020 17:26:02 +0000 Original-Received: (at 41086) by debbugs.gnu.org; 5 May 2020 17:25:05 +0000 Original-Received: from localhost ([127.0.0.1]:37282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW1JV-0005ja-Fj for submit@debbugs.gnu.org; Tue, 05 May 2020 13:25:05 -0400 Original-Received: from mail-qk1-f173.google.com ([209.85.222.173]:34743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW1JU-0005jN-99 for 41086@debbugs.gnu.org; Tue, 05 May 2020 13:25:00 -0400 Original-Received: by mail-qk1-f173.google.com with SMTP id t3so3152886qkg.1 for <41086@debbugs.gnu.org>; Tue, 05 May 2020 10:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IyRGrYefE9KGrkvVS3VfEg+NEAiLnmVn7HugXjJkbpk=; b=korXnc58TzQHrsdsevc4jr7mBYxElnlKCbi/VNaNeITM6jcI7kbWH5wYuLNcfzbma/ QtUFhIQuqyTDrpPti8gayuQnnN6ggPXt8FwBDEga0uTiN9Rg4OtJzYYa0JUu1W6F5SXM CGrZIJUSbJttPzqf4LHoUSIedvWVRzV5ro+jyxoLNdbIpoLmDL2pc23+VlauSNMSU887 s3+FgiYvT+jMB/XeAwG1b1HacB2JkaH9v6vndGdtyF7QkI/vMWMM2R6BxVBaTMpFwj50 Vdx36CSHzsy6MKox5ahJseIOHVCm9C5bGrQkqV+uc4fkkKEajPhDpInDscxsUh9HMfVX pFYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IyRGrYefE9KGrkvVS3VfEg+NEAiLnmVn7HugXjJkbpk=; b=sdlG5FxAQ1L6nqOFsyKZduIgB1hKNtOVg2te4Tz+nkUvHr14B91UKjcMRFjuSE1DBt Qra0am7Ts7QEWojnEAzXfA6ykBWfhUR4iF2jEaj1bD6Vl2WOFK8niSLE+D9s8v7PXyoa vGRjWr2D/NfzoKlbm0O8qSy3QPlyhGvU6v7STf3RHKIaCGax+5/YCp6dms25QtI5MqgO RUi66f3Hqe/weB/q1bkwC+Emoq7KX4yF8F7HrpT8Bvgdo58hiC4cPEkjxQEpRHgvstgn ijxp30sTkmR0PX4JTZZ10AutmtxQXAZIbwZ/ar2+iCTwcM1G6UIN/H/3uQYHNFRaRmR9 CH2A== X-Gm-Message-State: AGi0PuYzFh/KJjvVjSarnYj70UF/sIZceWoyrPl0EOjR7BwuVrZiPZPP vEtOok46a724DsXua8yDaCzLKZDN X-Google-Smtp-Source: APiQypKPj7cN6uZH5WDn36LxuIlMNTVkMYmk/kvToVP/49HS5NccGX/JMiZn87IAha7Cadn4hLlLRQ== X-Received: by 2002:a05:620a:13c1:: with SMTP id g1mr2001140qkl.257.1588699494009; Tue, 05 May 2020 10:24:54 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id u11sm2333811qtj.10.2020.05.05.10.24.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 May 2020 10:24:53 -0700 (PDT) In-Reply-To: (Chris McMahan's message of "Tue, 5 May 2020 13:12:26 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179747 Archived-At: Chris McMahan writes: > ;; Original non-functioning code. Trying to get the value of the > package-archive-column-width into the list rather than hardcode it. > (setq tabulated-list-format > `[("Package" ,package-name-column-width > package-menu--name-predicate) > ("Version" ,package-version-column-width > package-menu--version-predicate) > ("Status" ,package-status-column-width > package-menu--status-predicate)]) > ,@(if (cdr package-archives) > '(("Archive" ,package-archive-column-width ^ You just need a backquote here instead of a plain quote. A good rule of thumb is that if you climb up (using backward-up-list, C-M-u) from a comma, there should always be exactly one corresponding backquote per comma. In this case you had two commas, but only one backquote. > (if (cdr package-archives) > (setq tabulated-list-format (append tabulated-list-format `(("Archive" ,package-archive-column-width package-menu--archive-predicate))))) > (setq tabulated-list-format (append tabulated-list-format `(("Description" 0 package-menu--description-predicate)))) This works too, though it's a bit clunky. >> > I can't figure out how to get it to use the value of >> > package-archive-column-width and not the string literal. FYI, you really mean a quoted symbol, not a string literal.