all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: 21112@debbugs.gnu.org, Raffaele Ricciardi <rfflrccrd@gmail.com>
Subject: bug#21112: 25; Patch: show minibuffer messages with a face
Date: Tue, 25 Jun 2019 13:54:10 -0700 (PDT)	[thread overview]
Message-ID: <85ec41db-186f-4ab7-8660-5561f4599a27@default> (raw)
In-Reply-To: <87pnn11nm5.fsf@mail.linkov.net>

> For consistency with isearch messages that are highlighted with the
> minibuffer-prompt face, minibuffer-message needs to do the same.

Neither Isearch prompts nor `minibuffer-message' output
should be highlighted with face `minibuffer-prompt'.

Isearch doesn't use the minibuffer.
And `minibuffer-message' is not a prompt.

> But since a message is displayed at different part of the minibuffer,
> it should be highlighted using a new separate customizable variable
> similar to minibuffer-prompt-properties:

1. If you go that route, which lets libraries and
users easily change the properties (good), please
separate Isearch and `minibuffer-message'.  Use two
different variables.  They are not the same species.

The default value could be, but it need not be,
the same for both.

On the other hand, it could be helpful to separate
out property `face', defining an actual face (for
each of Isearch and `minibuffer-message') that
users can customize for this.  That also has the
benefit that one can inherit from one to the other.

The other properties would be applied first, so that
if `face' is among them for some reason it will be
overridden by the face provided specifically for this.

2. The doc string of `minibuffer-message-properties'
should not say that the properties are added to
"minibuffer messages" - that's too broad.  It should
say that they are added to the text shown by function
`minibuffer-message' - or else describe that text,
and only that text, in another way.

The doc string of the similar variable for Isearch
should say that the properties are added to "the
search prompt" or some such.  Not sure whether the
right description is "prompt", but whatever is the
best way to describe it should be used in the doc
string.





  parent reply	other threads:[~2019-06-25 20:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 12:46 bug#21112: 25; Patch: show minibuffer messages with a face Raffaele Ricciardi
2015-07-22 13:42 ` Drew Adams
2015-07-22 13:44   ` Drew Adams
2015-07-22 15:27     ` Raffaele Ricciardi
2015-07-22 15:42       ` Drew Adams
2016-02-23  9:34 ` Lars Ingebrigtsen
2019-06-25 15:50   ` Lars Ingebrigtsen
2019-06-25 19:47     ` Juri Linkov
2019-06-25 20:43       ` Lars Ingebrigtsen
2019-06-26 21:28         ` Juri Linkov
2019-06-27 10:28           ` Lars Ingebrigtsen
2019-06-27 14:22             ` Drew Adams
2019-06-27 20:29               ` Juri Linkov
2019-06-27 21:19                 ` Drew Adams
2019-06-27 20:28             ` Juri Linkov
2019-06-27 21:37               ` Drew Adams
2019-07-04 22:01         ` Juri Linkov
2019-06-25 20:54       ` Drew Adams [this message]
2019-06-26 21:30         ` Juri Linkov
2019-06-26 22:13           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85ec41db-186f-4ab7-8660-5561f4599a27@default \
    --to=drew.adams@oracle.com \
    --cc=21112@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=rfflrccrd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.