all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Wolfgang Jenkner <wjenkner@inode.at>
To: 11408@debbugs.gnu.org
Subject: bug#11408: 24.1.50; [PATCH] Don't inherit faces when untabifying the man page
Date: Fri, 04 May 2012 19:04:51 +0200	[thread overview]
Message-ID: <85d36jyh9z.fsf@iznogoud.viz> (raw)

Look a the emacs(1) man page

M-x m a n <return> e m a c s <return>

You may (or may not, depending on how your man program outputs tab
characters) observe that the underlining of some words protrudes to the
following white space.  E.g., I see occurrences of "Emacs  windows" or
"Emacs.   Help" where the (multiple) space characters are underlined.

GNU Emacs 24.1.50.1 (amd64-unknown-freebsd9.0, GTK+ Version 2.24.6)
 of 2012-05-02 on iznogoud.viz


2012-05-04  Wolfgang Jenkner  <wjenkner@inode.at>

	* man.el (Man-unindent): Use text-property-default-nonsticky to
	prevent untabify from inheriting `face' text properties.
	In particular, underlined white space didn't look so hot.


=== modified file 'lisp/man.el'
--- lisp/man.el	2012-04-28 21:59:08 +0000
+++ lisp/man.el	2012-05-04 16:18:33 +0000
@@ -1475,7 +1475,12 @@
 	    (nindent 0))
 	(narrow-to-region (car page) (car (cdr page)))
 	(if Man-uses-untabify-flag
-	    (untabify (point-min) (point-max)))
+	    (let ((text-property-default-nonsticky
+		   ;; The space characters `untabify' (or rather `indent-to')
+		   ;; inserts inherit sticky text properties, which is
+		   ;; unnecessary and looks exceedingly ugly with `underline'.
+		   (cons '(face . t) text-property-default-nonsticky)))
+	      (untabify (point-min) (point-max))))
 	(if (catch 'unindent
 	      (goto-char (point-min))
 	      (if (not (re-search-forward Man-first-heading-regexp nil t))







             reply	other threads:[~2012-05-04 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04 17:04 Wolfgang Jenkner [this message]
2012-05-06  4:19 ` bug#11408: 24.1.50; [PATCH] Don't inherit faces when untabifying the man page Chong Yidong
2012-05-06 13:57 ` Stefan Monnier
2012-05-06 15:31   ` Wolfgang Jenkner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85d36jyh9z.fsf@iznogoud.viz \
    --to=wjenkner@inode.at \
    --cc=11408@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.