all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: Andreas Schwab <schwab@suse.de>
Cc: emacs-pretest-bug@gnu.org, christopher.ian.moore@gmail.com,
	svenjoac@gmx.de, Stefan Monnier <monnier@iro.umontreal.ca>,
	rms@gnu.org
Subject: Re: creating backups in temporary directories
Date: Mon, 10 Sep 2007 03:11:31 +0200	[thread overview]
Message-ID: <85bqcbnx30.fsf@lola.goethe.zz> (raw)
In-Reply-To: <je7imzwpn1.fsf@sykes.suse.de> (Andreas Schwab's message of "Sun\, 09 Sep 2007 22\:27\:30 +0200")

Andreas Schwab <schwab@suse.de> writes:

> David Kastrup <dak@gnu.org> writes:
>
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>>> In a directory with mode 777, that's true: everything is dangerous.
>>> But in a directory with mode 1777 when you open a file that *you* own,
>>> nobody else can remove it or rename it, so normally nobody can replace it
>>> with a symlink.  Emacs creates the problem when it moves /tmp/foo to
>>> /tmp/foo~ at which point /tmp/foo is free for an attacker to take.
>>
>> Well, the alternative is to make a hard link of /tmp/foo to /tmp/foo~,
>> then creat /tmp/foo over it and fill it with contents without
>> reopening.
>>
>> That should close the time window for an attack.
>
> You have to unlink the file first,

Well, seems I misread the manual page for open/creat.  I thought that
without O_EXCL, the file would get replaced.

Well, then there still is the contorted way of hard linking /tmp/foo
to /tmp/foo~, opening /tmp/randomfilename for write, renaming it to
/tmp/foo and then finishing the write operation.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

  reply	other threads:[~2007-09-10  1:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-07 10:42 creating backups in temporary directories Chris Moore
2007-09-07 15:36 ` David Kastrup
2007-09-07 17:57   ` Stefan Monnier
2007-09-07 19:43     ` Davis Herring
2007-09-07 19:49     ` Sven Joachim
2007-09-07 19:52       ` David Kastrup
2007-09-08 19:47         ` Richard Stallman
2007-09-07 20:47       ` Stefan Monnier
2007-09-08 19:47         ` Richard Stallman
2007-09-09 19:44           ` Stefan Monnier
2007-09-09 20:01             ` David Kastrup
2007-09-09 20:27               ` Andreas Schwab
2007-09-10  1:11                 ` David Kastrup [this message]
2007-09-10 19:18                   ` Davis Herring
2007-09-10 19:55                     ` David Kastrup
     [not found]                   ` <37852.128.165.123.18.1189451917.squirrel@webmail.lanl.gov>
2007-09-10 19:23                     ` Davis Herring
2007-09-11 20:32                       ` Richard Stallman
2007-09-11 21:17                         ` Davis Herring
2007-09-10  1:12             ` Richard Stallman
2007-09-10  2:59               ` Stefan Monnier
2007-09-08 14:38     ` Chris Moore
2007-09-08 19:48     ` Richard Stallman
2007-09-09 19:41       ` Stefan Monnier
2007-09-09 19:45         ` David Kastrup
2007-09-10  1:12         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85bqcbnx30.fsf@lola.goethe.zz \
    --to=dak@gnu.org \
    --cc=christopher.ian.moore@gmail.com \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    --cc=schwab@suse.de \
    --cc=svenjoac@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.