* Any problem with this patch?
@ 2007-03-23 8:59 David Kastrup
2007-03-23 9:18 ` Herbert Euler
2007-03-23 9:19 ` Herbert Euler
0 siblings, 2 replies; 6+ messages in thread
From: David Kastrup @ 2007-03-23 8:59 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
I did not try it since I don't do much C editing, but it removes a
byte compiler warning and seems saner to me.
If anybody using CC mode would verify that this causes no problems,
I'd be grateful.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 724 bytes --]
*** cc-mode.el 12 Mar 2007 20:24:08 +0100 1.55
--- cc-mode.el 23 Mar 2007 09:56:24 +0100
***************
*** 158,165 ****
;; These are typically standard emacs variables such as `comment-start'.
(defmacro c-make-emacs-variables-local ()
`(progn
! ,@(mapcan (lambda (init)
! `((make-local-variable ',(car init))))
(cdr c-emacs-variable-inits))))
(defun c-init-language-vars-for (mode)
--- 158,165 ----
;; These are typically standard emacs variables such as `comment-start'.
(defmacro c-make-emacs-variables-local ()
`(progn
! ,@(mapcar (lambda (init)
! `(make-local-variable ',(car init)))
(cdr c-emacs-variable-inits))))
(defun c-init-language-vars-for (mode)
[-- Attachment #3: Type: text/plain, Size: 52 bytes --]
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
[-- Attachment #4: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: Any problem with this patch?
2007-03-23 8:59 Any problem with this patch? David Kastrup
@ 2007-03-23 9:18 ` Herbert Euler
2007-03-23 9:27 ` David Kastrup
2007-03-23 9:19 ` Herbert Euler
1 sibling, 1 reply; 6+ messages in thread
From: Herbert Euler @ 2007-03-23 9:18 UTC (permalink / raw)
To: dak, emacs-devel
>I did not try it since I don't do much C editing, but it removes a
>byte compiler warning and seems saner to me.
>
>If anybody using CC mode would verify that this causes no problems,
>I'd be grateful.
I got the error when loading a C file:
File mode specification error: (invalid-function (make-local-variable (quote
comment-start)))
Regards,
Guanpeng Xu
_________________________________________________________________
FREE pop-up blocking with the new MSN Toolbar - get it now!
http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Any problem with this patch?
2007-03-23 9:18 ` Herbert Euler
@ 2007-03-23 9:27 ` David Kastrup
2007-03-23 9:33 ` Herbert Euler
0 siblings, 1 reply; 6+ messages in thread
From: David Kastrup @ 2007-03-23 9:27 UTC (permalink / raw)
To: Herbert Euler; +Cc: emacs-devel
"Herbert Euler" <herberteuler@hotmail.com> writes:
>>I did not try it since I don't do much C editing, but it removes a
>>byte compiler warning and seems saner to me.
>>
>>If anybody using CC mode would verify that this causes no problems,
>>I'd be grateful.
>
> I got the error when loading a C file:
>
> File mode specification error: (invalid-function (make-local-variable
> (quote comment-start)))
I can't reproduce this. Did you possibly apply the patch _manually_
(and overlooked that it removes one level of braces)?
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Any problem with this patch?
2007-03-23 9:27 ` David Kastrup
@ 2007-03-23 9:33 ` Herbert Euler
2007-03-23 9:46 ` David Kastrup
0 siblings, 1 reply; 6+ messages in thread
From: Herbert Euler @ 2007-03-23 9:33 UTC (permalink / raw)
To: dak; +Cc: emacs-devel
>I can't reproduce this. Did you possibly apply the patch _manually_
>(and overlooked that it removes one level of braces)?
Sorry, the error was actually caused by my mistake when I manually
applied the patch. Yes, I counted braces wrong. And the file is
opened correctly now. At least there is no obvious problem I can
see.
Regards,
Guanpeng Xu
_________________________________________________________________
FREE pop-up blocking with the new MSN Toolbar - get it now!
http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Any problem with this patch?
2007-03-23 9:33 ` Herbert Euler
@ 2007-03-23 9:46 ` David Kastrup
0 siblings, 0 replies; 6+ messages in thread
From: David Kastrup @ 2007-03-23 9:46 UTC (permalink / raw)
To: Herbert Euler; +Cc: emacs-devel
"Herbert Euler" <herberteuler@hotmail.com> writes:
>>I can't reproduce this. Did you possibly apply the patch _manually_
>>(and overlooked that it removes one level of braces)?
>
> Sorry, the error was actually caused by my mistake when I manually
> applied the patch. Yes, I counted braces wrong. And the file is
> opened correctly now. At least there is no obvious problem I can
> see.
Since it fixes one warning (which might or might not be a problem) and
since it got quite more testing than intended (I disassembled macro
and its caller to make sure that it worked), I'm confident enough to
check this in now.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: Any problem with this patch?
2007-03-23 8:59 Any problem with this patch? David Kastrup
2007-03-23 9:18 ` Herbert Euler
@ 2007-03-23 9:19 ` Herbert Euler
1 sibling, 0 replies; 6+ messages in thread
From: Herbert Euler @ 2007-03-23 9:19 UTC (permalink / raw)
To: dak, emacs-devel
Sorry but the backtrace:
Debugger entered--Lisp error: (invalid-function (make-local-variable (quote
comment-start)))
((make-local-variable (quote comment-start)))
(progn ((make-local-variable ...)) ((make-local-variable ...))
((make-local-variable ...)))
(c-make-emacs-variables-local)
c-init-language-vars-for(c-mode)
c-mode()
set-auto-mode-0(c-mode nil)
set-auto-mode()
normal-mode(t)
after-find-file(nil t)
find-file-noselect-1(#<buffer x.c> "~/x.c" nil nil "~/x.c" (17889 (17223 .
42209)))
find-file-noselect("d:/home/xugp/x.c" nil nil)
ido-file-internal(raise-frame)
ido-find-file()
call-interactively(ido-find-file)
Regards,
Guanpeng Xu
_________________________________________________________________
FREE pop-up blocking with the new MSN Toolbar - get it now!
http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-03-23 9:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-23 8:59 Any problem with this patch? David Kastrup
2007-03-23 9:18 ` Herbert Euler
2007-03-23 9:27 ` David Kastrup
2007-03-23 9:33 ` Herbert Euler
2007-03-23 9:46 ` David Kastrup
2007-03-23 9:19 ` Herbert Euler
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.