From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Fixing numerous `message' bugs.. Date: Mon, 10 Dec 2007 22:19:34 +0100 Message-ID: <85aboint7d.fsf@lola.goethe.zz> References: <87myso8yrs.fsf@marie.gnufans.net> <87ve7b4xt6.fsf@marie.gnufans.net> <85abonpxnw.fsf@lola.goethe.zz> <85fxyel8o8.fsf@lola.goethe.zz> <87hciugzal.fsf@marie.gnufans.net> <87ir36o3as.fsf@marie.gnufans.net> <475D7F91.80503@gnu.org> <877ijmmkuq.fsf@marie.gnufans.net> <87aboijnqn.fsf@marie.gnufans.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1197324043 23868 80.91.229.12 (10 Dec 2007 22:00:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Dec 2007 22:00:43 +0000 (UTC) Cc: Andreas Schwab , Jason Rumney , Richard Stallman , emacs-devel@gnu.org To: Dave Goel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 10 23:00:52 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J1qgF-0004qm-Nb for ged-emacs-devel@m.gmane.org; Mon, 10 Dec 2007 23:00:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1qfy-0005E3-50 for ged-emacs-devel@m.gmane.org; Mon, 10 Dec 2007 17:00:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J1qfu-0005Dx-PC for emacs-devel@gnu.org; Mon, 10 Dec 2007 17:00:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J1qfs-0005Dc-UY for emacs-devel@gnu.org; Mon, 10 Dec 2007 17:00:30 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1qfs-0005DW-RR for emacs-devel@gnu.org; Mon, 10 Dec 2007 17:00:28 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J1qft-0002p7-5Y for emacs-devel@gnu.org; Mon, 10 Dec 2007 17:00:29 -0500 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J1qfm-0001FF-8T; Mon, 10 Dec 2007 17:00:22 -0500 Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 570691C4CE33; Mon, 10 Dec 2007 22:19:33 +0100 (CET) In-Reply-To: <87aboijnqn.fsf@marie.gnufans.net> (Dave Goel's message of "Mon, 10 Dec 2007 15:31:12 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84981 Archived-At: Dave Goel writes: > Andreas Schwab writes: > > >> want to use EQ instead anyway, since you are comparing with a symbol. > > Thanks. Attached is a new patch, which also seems much more elegant. > I am not a C expert. Can some one comment on it? Shall I commit it? Considering that the idiom (message "%s" (or x "")) will work instead of the proposed (message t x) and considering that it rarely occurs (I think I should have got most cases), I don't think it is really worth the trouble. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum