From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.devel Subject: Re: Aligned blocks management: obsolete? Date: Wed, 20 Jun 2012 19:59:04 +0200 Message-ID: <85a9zxoo6x.fsf@iznogoud.viz> References: <4EE5B744.1090103@yandex.ru> <4EE60A93.9060401@yandex.ru> <4EE6478C.1020701@cs.ucla.edu> <4FE0ADFC.9090504@yandex.ru> <4FE171EC.8000503@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1340215458 9165 80.91.229.3 (20 Jun 2012 18:04:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 20 Jun 2012 18:04:18 +0000 (UTC) Cc: Eli Zaretskii , Paul Eggert , Stefan Monnier , Emacs development discussions To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 20 20:04:17 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ShPGI-0000jr-RR for ged-emacs-devel@m.gmane.org; Wed, 20 Jun 2012 20:04:14 +0200 Original-Received: from localhost ([::1]:34026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShPGI-0008Na-MR for ged-emacs-devel@m.gmane.org; Wed, 20 Jun 2012 14:04:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShPGF-0008NA-Rd for emacs-devel@gnu.org; Wed, 20 Jun 2012 14:04:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShPG6-0008Q0-64 for emacs-devel@gnu.org; Wed, 20 Jun 2012 14:04:11 -0400 Original-Received: from mx02.lb01.inode.at ([62.99.145.2]:13857 helo=mx.inode.at) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShPG0-0008HS-98; Wed, 20 Jun 2012 14:03:56 -0400 Original-Received: from [91.119.143.36] (port=3150 helo=iznogoud.viz) by smartmx-02.inode.at with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1ShPFx-0004HT-Q3; Wed, 20 Jun 2012 20:03:53 +0200 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.77 (FreeBSD)) (envelope-from ) id 1ShPFu-000HZ1-Ef; Wed, 20 Jun 2012 20:03:50 +0200 Mail-Followup-To: Dmitry Antipov , Stefan Monnier , Paul Eggert , Eli Zaretskii , Emacs development discussions User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (berkeley-unix) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 62.99.145.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151058 Archived-At: On Wed, Jun 20 2012, Dmitry Antipov wrote: > This code tries to utilize system malloc features and falls back to legacy > aligned blocks management code if system malloc implementation is unknown, > broken, or lacks aligned allocation routines. I think the following trivial fix is needed (relative to your patch): Wolfgang diff --git a/src/alloc.c b/src/alloc.c index 15cefb5..4cd3a32 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -894,7 +894,7 @@ void *lisp_malloc_loser EXTERNALLY_VISIBLE; /* Nonzero if the memory at ADDR can be addressed thru a Lisp object's pointer. */ -static inline void +static inline int verify_address (char *addr) { Lisp_Object obj;