From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE Date: Thu, 27 Apr 2023 12:56:07 -0700 Message-ID: <85A2194C-5C67-4AC2-A265-9C20F03FA5B6@gmail.com> References: <82E7ADEC-25BC-475B-8EE0-839FE78FF2F4@gmail.com> <83fs8s2xnk.fsf@gnu.org> <2BDA88D0-A870-4FE3-BAF8-350FBAA943BF@gmail.com> <384f8110-eba6-8fb3-ef4e-56fa0721d85d@gutov.dev> <90E66143-A3E2-4B76-AC0A-01DC5E841AFE@gmail.com> <36F36D54-E56C-42C8-B686-448C8BF938EA@gmail.com> <83jzxxs6yn.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2299"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 62951@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 27 21:57:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ps7jz-0000Qv-UO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Apr 2023 21:57:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ps7jm-0005xH-Gn; Thu, 27 Apr 2023 15:57:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps7ji-0005x0-UF for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 15:57:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ps7ji-0007WQ-HB for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 15:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ps7ji-0002zl-CY for bug-gnu-emacs@gnu.org; Thu, 27 Apr 2023 15:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Apr 2023 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62951 X-GNU-PR-Package: emacs Original-Received: via spool by 62951-submit@debbugs.gnu.org id=B62951.168262538911474 (code B ref 62951); Thu, 27 Apr 2023 19:57:02 +0000 Original-Received: (at 62951) by debbugs.gnu.org; 27 Apr 2023 19:56:29 +0000 Original-Received: from localhost ([127.0.0.1]:59863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps7jA-0002yz-Pp for submit@debbugs.gnu.org; Thu, 27 Apr 2023 15:56:29 -0400 Original-Received: from mail-pf1-f171.google.com ([209.85.210.171]:55628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps7j8-0002yl-GL for 62951@debbugs.gnu.org; Thu, 27 Apr 2023 15:56:26 -0400 Original-Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-63b5c4c769aso11099981b3a.3 for <62951@debbugs.gnu.org>; Thu, 27 Apr 2023 12:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682625380; x=1685217380; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aG1eIkyH0RmuLRiAJmc0g9+HliRjtKlB5JGZchelrpI=; b=BG9IUQrmTSOyaJ1I+nic1Yw49Cv0yQF4Pth4UgV0HaqcAAIczKnqCZyIAzcdkdkO2x N/lkTGUtEvNhmKvDEy4IENn6AAzIWM7QkLGlemmjdGQPMt0S7CJDwBQAqoBgry0RP3GF TNWD/4mV8Q/KjhqfpkuHuBQfV3zE3Qux3QaJ25xRcYNiQIOn6LbFPWmt29jQWF2plk42 rYeiELgZjyRosw9AwhpOOvqEcrp6Mc/gSiIUnwJzx1A1KjATcC9bmQx2o42xecNSyEmA 3x3yNiejXvpUccHLQgrrF8L4aKSebAj3/56wRu76WE8HSYrWrUmEmz1YN0vH28woRsKX p5Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682625380; x=1685217380; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aG1eIkyH0RmuLRiAJmc0g9+HliRjtKlB5JGZchelrpI=; b=OZmg5HWa3FUsneGVSrOthCT5hU/WGc6G33x7tjm06flOp6lBikOed8xEB/KJerj+xb mvktM68ZgkaBgy9A2rAOFVCipDzX/dlSd//KdFwIJfPTCc2od06pyITouZ/03ksuB2z0 7WgrQ4pZWNdzItfPY6D03h//nIUHsXQSy6XlbCHUUdan2oKSpWWlFtj2eVLtNpOK7p/U uWUZb9kGuu8grpmAJgb83Lx7RqpoR6V2c7+CsudGV7AKWZvnu5P4+B0T/2U2+B5GbwK3 9ECmuBuCZMwnkMyKmipvr2yGfjUrAndq4K2Y6jjVdhVhdOQB9cqaW3VX6EfRbKjhSMQv 0lgQ== X-Gm-Message-State: AC+VfDx0uSyBwseIfz02UZRPsBWAzCU8GeSoGUmOPd7x32Ouai2pAbcJ 33rgfapnz4lW444Hx57qyq4= X-Google-Smtp-Source: ACHHUZ78stmdCBQff7SSD1SgtPZLMgjP7J4wb5Um6Chy7xaj7cCuqXEotcqKu83ODcYP6R7niOTxMQ== X-Received: by 2002:a05:6a00:1946:b0:63d:3ae4:7c72 with SMTP id s6-20020a056a00194600b0063d3ae47c72mr3347684pfk.0.1682625380050; Thu, 27 Apr 2023 12:56:20 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id o64-20020a62cd43000000b0063d642dcd12sm14029357pfg.16.2023.04.27.12.56.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Apr 2023 12:56:19 -0700 (PDT) In-Reply-To: <83jzxxs6yn.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.500.231) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260736 Archived-At: > On Apr 27, 2023, at 8:03 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Wed, 26 Apr 2023 20:14:45 -0700 >> Cc: Eli Zaretskii , >> 62951@debbugs.gnu.org >>=20 >> Ok, here=E2=80=99s the patch. Eli, would you give it a try? >=20 > It signals an error when I enable c-ts-mode: >=20 > c-ts-mode: Cannot load language definition: not-found, = ("libtree-sitter-emacs-c" "libtree-sitter-emacs-c.dll"), "No such file = or directory" >=20 > It looks like your "fake emacs-c language" trick somehow misfires? > The value of treesit-load-name-override-list is nil, which is not what > you intended, AFAICT? The only way I can make this work is by > manually customizing treesit-load-name-override-list before loading > c-ts-mode. Duh, sorry, dumb mistake. Fixed. >=20 > Otherwise, looks quite good; here are some other problems I found: >=20 > . some uses of FOR_EACH_TAIL are not fontified at all; examples: > comp.c, line 2079, fns.c, line 189 You mean the FOE_EACH_TAIL part isn=E2=80=99t fontified, or the body = isn=E2=80=99t fontified? Because the body are always fontified here. = FOR_EACH_TAIL itself shouldn=E2=80=99t be fontified since it=E2=80=99s = just a macro call and a variable. > . FOR_EACH_LIVE_BUFFER (data.c, line 1430) is not recognized? > . FOR_EACH_FRAME (keyboard.c, line 1256) is not recognized? Didn=E2=80=99t know that they exited :-) Now I have FOR_EACH_TAIL, = FOR_EACH_TAIL_SAFE, FOR_EACH_ALIST_VALUE, FOR_EACH_LIVE_BUFFER, = FOR_EACH_FRAME. >=20 > This is much better than before already, so I think you should install > this on the emacs-29 branch, once you fix the above problems (assuming > they are easily fixable). Cool, I pushed the change. Yuan=