From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6) Date: Sat, 14 Nov 2015 15:23:50 -0500 Message-ID: <859F5387-32A9-4613-BED6-A0FA4D849B38@gmail.com> References: <563F4B17.6090308@porkrind.org> <56424784.2070600@porkrind.org> <50B60CF8-CBE3-4DF1-8E44-9C6DD5883C6E@gmail.com> <3F4353A6-B088-4DC3-B196-F7AB3EFE5FCE@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1447652907 18478 80.91.229.3 (16 Nov 2015 05:48:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Nov 2015 05:48:27 +0000 (UTC) Cc: John Wiegley , 21862@debbugs.gnu.org, 21862-done@debbugs.gnu.org, David Caldwell To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 16 06:48:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZyCeD-0002nq-Vl for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Nov 2015 06:48:14 +0100 Original-Received: from localhost ([::1]:45645 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyCeD-0002dG-9A for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Nov 2015 00:48:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxhMj-0008Og-7p for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 15:24:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxhMg-000386-4q for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 15:24:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxhMg-00037s-1G for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 15:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZxhMf-0003a9-QW for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 15:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Reitter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2015 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21862-submit@debbugs.gnu.org id=B21862.144753263513751 (code B ref 21862); Sat, 14 Nov 2015 20:24:01 +0000 Original-Received: (at 21862) by debbugs.gnu.org; 14 Nov 2015 20:23:55 +0000 Original-Received: from localhost ([127.0.0.1]:38271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxhMZ-0003Zh-0G for submit@debbugs.gnu.org; Sat, 14 Nov 2015 15:23:55 -0500 Original-Received: from mail-qk0-f170.google.com ([209.85.220.170]:33573) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZxhMX-0003ZX-7j; Sat, 14 Nov 2015 15:23:53 -0500 Original-Received: by qkas77 with SMTP id s77so80057015qka.0; Sat, 14 Nov 2015 12:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=AJiSSlLLUppKx394kgCoky3zeyaVQ5G5cMeAFq4p7R8=; b=jBNWQ0ZlhHgnuB2YTzz9tft/yxpGSK4p/1shxjzcyBbVDLmF6aRijqa1xUDsBIelB9 GXkcjROfCi/41jBkZKvOCZp71DlBS+Tl2WtfGRvTDSJC2N6PaDhCIkKh458SZeCSA/1O iyUukfvfENiG+28NZjS9hjQMEKjC6wWj3mGr1wJOstkjH0J8qiZdO3Wp9hXcmUwoX/wC jqYoc7rTTGPegdG0ks/OulhYzlVza9oEfEfY+ej56yNeh/n71S5vORYiXN9Bkt3r2+uY OSf9eN6Mwjn/gdXUzDr+Bl/w3GDUboHp5wzbYxf/NswQ6mBjLXKqbPnCCygTmicIDT6I Gf8g== X-Received: by 10.55.75.84 with SMTP id y81mr26382410qka.96.1447532632765; Sat, 14 Nov 2015 12:23:52 -0800 (PST) Original-Received: from [10.0.1.23] (c-71-58-212-112.hsd1.pa.comcast.net. [71.58.212.112]) by smtp.gmail.com with ESMTPSA id o6sm6866926qko.34.2015.11.14.12.23.51 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Nov 2015 12:23:51 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3094) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108744 Archived-At: On Nov 14, 2015, at 3:14 PM, Anders Lindgren wrote: > David (R), if you think this is a good way to solve this, would you = like to commit this patch, or would you prefer me to do it? Yes, defining an extra windowDidBecomeKey function is prettier. I think that=E2=80=99s okay to check in to master. =20 For emacs-25, I think it=E2=80=99s good, too, as it is part of the = original compile bug fix and reduces the chance of future problems = rather than increasing it. I defer to John Wiegley (cc=E2=80=99ed) = regarding this. Anders, I do think that the cleaner way would be to use notifications to = run these functions, which might reduce extra calls. However, that = requires more testing that I was willing to do (on GNUStep too), because = there=E2=80=99s potential for these methods getting called at a later = point in time. - David=