From: Dmitry Gutov <dgutov@yandex.ru>
To: Zhiwei Chen <condy0919@gmail.com>, 44210@debbugs.gnu.org
Subject: bug#44210: 28.0.50; project.el failed to work after customizing find-program to fd
Date: Tue, 27 Oct 2020 00:37:10 +0200 [thread overview]
Message-ID: <85912943-41db-4c6c-3764-0aa6d01f54ec@yandex.ru> (raw)
In-Reply-To: <87zh4ak0lr.fsf@gmail.com>
Hi!
On 25.10.2020 13:26, Zhiwei Chen wrote:
> The arguments of `find-program' in function
> `project--files-in-directory' is hard coded, which disallows customizing
> `find-program' in some means.
The arguments are not hardcoded (they are constructed dynamically), but
the format is (one expected by 'find').
'fd' uses a different arguments format, both for the "globs to search
for" and the list of ignores. I wish we had a better mechanism in
grep.el for a more flexible user ability to choose the tool to list
files in a dir (and a search tool, and so on).
> `counsel-file-jump` uses `find-program' and provides
> `counsel-file-jump-args' which I thought is better.
A variable with a flat list of args won't do here, because we actually
have to turn two other lists (FILES and IGNORES) into appropriate arguments.
What you could do, is do full :override advice on which would construct
a proper command line for 'fd' based on these args, then call it and
pipe through 'project--remote-file-names' (like
'project--files-in-directory' currently does). Then benchmark them and
post the results here.
If the result offers a meaningfully better performance, while honoring
all ignores, we'll see what we can do to accommodate 'fd'.
next prev parent reply other threads:[~2020-10-26 22:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 11:26 bug#44210: 28.0.50; project.el failed to work after customizing find-program to fd Zhiwei Chen
2020-10-26 22:37 ` Dmitry Gutov [this message]
2021-01-10 3:31 ` Zhiwei Chen
2021-01-10 3:37 ` Zhiwei Chen
2021-01-10 17:48 ` Dmitry Gutov
2021-01-18 1:15 ` Zhiwei Chen
2021-01-18 3:09 ` Dmitry Gutov
2021-01-11 13:04 ` Zhiwei Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85912943-41db-4c6c-3764-0aa6d01f54ec@yandex.ru \
--to=dgutov@yandex.ru \
--cc=44210@debbugs.gnu.org \
--cc=condy0919@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.