From: Jared Finder via "Emacs development discussions." <emacs-devel@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Additional cleanup around xterm-mouse
Date: Sun, 20 Dec 2020 15:27:10 -0800 [thread overview]
Message-ID: <858d85fc265455042479cb4c9a72b4a5@finder.org> (raw)
In-Reply-To: <jwv4kkglgly.fsf-monnier+emacs@gnu.org>
On 2020-12-20 6:07 am, Stefan Monnier wrote:
>> I see a few options:
>>
>> 1. Change the behavior of the dont-downcase-last parameter to this
>> more
>> extensive meaning. Update global-set-key (the only other caller
>> who sets
>> dont-downcase-last in Emacs' code) to take this new behavior
>> into account.
>
> I believe `global-set-key` does want to use this new behavior, yes.
>
>> 2. Make the dont-downcase-last parameter have the new behavior only if
>> it is
>> passed some new value (for example: 'all-fallbacks). Leave the
>> existing
>> behavior for any other value, especially 'nil and 't.
>>
>> 3. [My preference] Like 2, but with a deprecation message on values
>> other
>> than 'nil, 'all-fallbacks, or 't (or maybe 'downcase-last if we
>> want full
>> explicitness). This allows maximal ability to define new behaviors
>> in
>> the future.
>
> These sound good as well. I'd even put a deprecation message on the
> `downcase-last` case.
>
>> I like #3 as existing code would run unchanged. The chance that any
>> existing code passed 'all-fallbacks is extremely low. And anyone
>> supporting
>> a package outside of Emacs passing some other value will notice the
>> message
>> when they upgrade to Emacs 28.
>>
>> Thoughts?
>
> By order of preference, I'd say: #1, then #3 and finally #2.
> But any one of those 3 is OK for me.
Sounds good to me! Eli, do you have a preference here? I'd like to make
sure I implement the right option.
-- MJF
next prev parent reply other threads:[~2020-12-20 23:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 6:29 Additional cleanup around xterm-mouse Jared Finder via Emacs development discussions.
2020-11-16 17:30 ` Jared Finder via Emacs development discussions.
2020-11-18 17:40 ` Eli Zaretskii
2020-11-19 8:03 ` Jared Finder via Emacs development discussions.
2020-11-21 9:31 ` Eli Zaretskii
2020-11-22 23:56 ` Jared Finder via Emacs development discussions.
2020-11-28 16:36 ` Eli Zaretskii
2020-12-01 7:36 ` Jared Finder via Emacs development discussions.
2020-12-01 15:21 ` Stefan Monnier
2020-12-01 18:23 ` Eli Zaretskii
2020-12-02 6:45 ` Jared Finder via Emacs development discussions.
2020-12-02 16:53 ` Stefan Monnier
2020-12-03 5:46 ` Jared Finder via Emacs development discussions.
2020-12-03 14:45 ` Stefan Monnier
2020-12-03 17:31 ` Jared Finder via Emacs development discussions.
2020-12-14 0:54 ` Jared Finder via Emacs development discussions.
2020-12-14 15:32 ` Eli Zaretskii
2020-12-16 5:30 ` Jared Finder via Emacs development discussions.
2020-12-19 18:32 ` Eli Zaretskii
2020-12-19 22:50 ` Stefan Monnier
2020-12-20 7:26 ` Jared Finder via Emacs development discussions.
2020-12-20 14:07 ` Stefan Monnier
2020-12-20 23:27 ` Jared Finder via Emacs development discussions. [this message]
2020-12-23 16:52 ` Eli Zaretskii
2020-12-23 17:21 ` Jared Finder via Emacs development discussions.
2020-12-24 18:43 ` Eli Zaretskii
2020-12-14 0:36 ` Jared Finder via Emacs development discussions.
2020-11-21 17:00 ` Stefan Monnier
2020-11-21 8:23 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2020-12-26 23:49 Jared Finder via Emacs development discussions.
2020-12-27 15:36 ` Stefan Monnier
2020-12-27 16:30 ` Jared Finder via Emacs development discussions.
2020-12-27 17:10 ` Stefan Monnier
2020-12-28 0:22 ` Jared Finder via Emacs development discussions.
2021-01-02 8:17 ` Eli Zaretskii
2021-01-02 22:20 ` Jared Finder via Emacs development discussions.
2021-01-09 12:27 ` Eli Zaretskii
2021-01-09 23:01 ` Jared Finder via Emacs development discussions.
2021-01-15 11:54 ` Eli Zaretskii
2020-11-15 8:49 Jared Finder via Emacs development discussions.
2020-11-15 18:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=858d85fc265455042479cb4c9a72b4a5@finder.org \
--to=emacs-devel@gnu.org \
--cc=eliz@gnu.org \
--cc=jared@finder.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.