* bug#8178: [PATCH] vc-dir.el -- Use different color for state edited
@ 2011-03-05 11:39 Jari Aalto
2011-05-22 19:36 ` Chong Yidong
2021-01-30 13:46 ` Dmitry Gutov
0 siblings, 2 replies; 3+ messages in thread
From: Jari Aalto @ 2011-03-05 11:39 UTC (permalink / raw)
To: 8178
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
Package: emacs
Version: Version Control as 2011-03-05 13:39 UTC of git 607177f
Severity: wishlist
When files marked with "edited" are shown in different color, it's easier
to find those that need to be committed.
2011-03-05 Jari Aalto <jari.aalto@cante.net>
* vc-dir.el (vc-default-dir-printer): For state "edited", use
`font-lock-constant-face'.
-- System Information
Debian Release: wheezy/sid
APT Prefers testing
APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Wed Jan 12 03:40:32 UTC 2011 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8
-- Versions of packages `emacs depends on'.
Depends:
emacs23 23.2+1-7 GNU Emacs is the extensible self-documenting
emacs23-lucid 23.2+1-7 GNU Emacs is the extensible self-documenting
emacs23-nox 23.2+1-7 GNU Emacs is the extensible self-documenting
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-vc-dir.el-Use-font-lock-constant-face-for-state.patch --]
[-- Type: text/x-diff, Size: 967 bytes --]
From 607177fd88616a21075d57831dfd77a296b70aa3 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Sat, 5 Mar 2011 13:35:13 +0200
Subject: [PATCH] lisp/vc-dir.el: Use font-lock-constant-face for state edited
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
lisp/vc-dir.el | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lisp/vc-dir.el b/lisp/vc-dir.el
index 61cc857..1b2352c 100644
--- a/lisp/vc-dir.el
+++ b/lisp/vc-dir.el
@@ -1190,6 +1190,7 @@ These are the commands available for use in the file status buffer:
(format "%-20s" state)
'face (cond ((eq state 'up-to-date) 'font-lock-builtin-face)
((memq state '(missing conflict)) 'font-lock-warning-face)
+ ((eq state 'edited) 'font-lock-constant-face)
(t 'font-lock-variable-name-face))
'mouse-face 'highlight)
" "
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#8178: [PATCH] vc-dir.el -- Use different color for state edited
2011-03-05 11:39 bug#8178: [PATCH] vc-dir.el -- Use different color for state edited Jari Aalto
@ 2011-05-22 19:36 ` Chong Yidong
2021-01-30 13:46 ` Dmitry Gutov
1 sibling, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2011-05-22 19:36 UTC (permalink / raw)
To: Jari Aalto; +Cc: 8178
Jari Aalto <jari.aalto@cante.net> writes:
> When files marked with "edited" are shown in different color, it's easier
> to find those that need to be committed.
>
> 2011-03-05 Jari Aalto <jari.aalto@cante.net>
>
> * vc-dir.el (vc-default-dir-printer): For state "edited", use
> `font-lock-constant-face'.
Looks reasonable. Committed to trunk, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#8178: [PATCH] vc-dir.el -- Use different color for state edited
2011-03-05 11:39 bug#8178: [PATCH] vc-dir.el -- Use different color for state edited Jari Aalto
2011-05-22 19:36 ` Chong Yidong
@ 2021-01-30 13:46 ` Dmitry Gutov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Gutov @ 2021-01-30 13:46 UTC (permalink / raw)
To: 8178; +Cc: Chong Yidong, Jari Aalto
Hi all,
I'm looking at this change now (a bit late, yeah), and it seems
inconsistent.
If the idea is to "find those that need to be committed", then what
about the 'added' state? Or 'removed'?
Won't that leave out only 'ignored' and 'unregistered' then? With
'conflict' and 'missing' being highlighted with 'warning'.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-30 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-05 11:39 bug#8178: [PATCH] vc-dir.el -- Use different color for state edited Jari Aalto
2011-05-22 19:36 ` Chong Yidong
2021-01-30 13:46 ` Dmitry Gutov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.