From: Wolfgang Jenkner <wjenkner@inode.at>
To: Alan Mackenzie <acm@muc.de>
Cc: Richard Stallman <rms@gnu.org>, emacs-devel@gnu.org
Subject: Re: Bugs #7240, #9133 - fixing them both at the same time.
Date: Sat, 24 Sep 2011 01:45:55 +0200 [thread overview]
Message-ID: <857h4yhlfw.fsf@iznogoud.viz> (raw)
In-Reply-To: <20110923192639.GB2562@acm.acm> (Alan Mackenzie's message of "Fri, 23 Sep 2011 19:26:39 +0000")
Alan Mackenzie <acm@muc.de> writes:
> The cause of these failures was trying to make one variable, par-beg, do
> two different jobs, namely 1) beginning of the paragraph; 2) start of
> text in the paragraph.
>
> By separating these out into par-beg and text-beg the bug simply
> evaporates.
So part of your change is
> (let ((opoint (point))
> (sentence-end (sentence-end)))
> (while (< arg 0)
> ! (let* ((pos (point))
> ! (text-beg
> ! (progn (start-of-paragraph-text)
> ! (point)))
[...]
> (goto-char (match-end 0))
> ! (goto-char text-beg)))
and my whole patch is
(goto-char (match-end 0))
- (goto-char par-beg)))
+ (goto-char opoint)
+ (start-of-paragraph-text)))
This is equivalent. Of course, style matters.
The rest of your change (with respect to the code before rms patched it)
consists in adding the 4th and 5th line in
> ! (par-beg
> ! (progn
> ! (backward-paragraph)
> ! (if (looking-at paragraph-separate)
> ! (forward-line))
> ! (point))))
That may be a good change, but it is not directly related to the bugs.
> Please try out the following patch and confirm to me that it's OK. Then
> I will commit it.
Oh my. I'm afraid you got a code review instead;-)
> Wolfgang: Thanks very much for taking the trouble to report this bug,
> submitting a patch (even if it wasn't quite right),
Wolfgang
next prev parent reply other threads:[~2011-09-23 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 19:26 Bugs #7240, #9133 - fixing them both at the same time Alan Mackenzie
2011-09-23 23:45 ` Wolfgang Jenkner [this message]
2011-09-24 12:28 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857h4yhlfw.fsf@iznogoud.viz \
--to=wjenkner@inode.at \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.