From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#20084: comint-highlight-prompt overrides ANSI colors in 24.4 Date: Mon, 23 Mar 2015 20:06:57 +0100 Message-ID: <857fu75xyx.fsf@iznogoud.viz> References: <1vy4n3gxzr.fsf@fencepost.gnu.org> <85k2ynexw9.fsf@iznogoud.viz> <85d244tmzb.fsf@iznogoud.viz> <85zj75gfki.fsf@iznogoud.viz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1427138067 7744 80.91.229.3 (23 Mar 2015 19:14:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Mar 2015 19:14:27 +0000 (UTC) Cc: 20084@debbugs.gnu.org, Charles Tam To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 23 20:14:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ya7nd-0004Er-T3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Mar 2015 20:14:10 +0100 Original-Received: from localhost ([::1]:57639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya7nd-0004Rs-82 for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Mar 2015 15:14:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya7na-0004Rn-4A for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2015 15:14:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya7nW-0004L3-TP for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2015 15:14:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya7nW-0004Kz-Py for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2015 15:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ya7nW-0007gL-EN for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2015 15:14:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Mar 2015 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20084 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 20084-submit@debbugs.gnu.org id=B20084.142713800129472 (code B ref 20084); Mon, 23 Mar 2015 19:14:02 +0000 Original-Received: (at 20084) by debbugs.gnu.org; 23 Mar 2015 19:13:21 +0000 Original-Received: from localhost ([127.0.0.1]:34138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ya7mq-0007fI-Lp for submit@debbugs.gnu.org; Mon, 23 Mar 2015 15:13:21 -0400 Original-Received: from b2bfep12.mx.upcmail.net ([62.179.121.57]:58977) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ya7mo-0007f3-Af for 20084@debbugs.gnu.org; Mon, 23 Mar 2015 15:13:19 -0400 Original-Received: from edge11.upcmail.net ([192.168.13.81]) by b2bfep12.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150323191311.ZBVS4373.b2bfep12-int.chello.at@edge11.upcmail.net> for <20084@debbugs.gnu.org>; Mon, 23 Mar 2015 20:13:11 +0100 Original-Received: from iznogoud.viz ([85.127.82.165]) by edge11.upcmail.net with edge id 77DA1q00y3a0xZ90B7DAQm; Mon, 23 Mar 2015 20:13:11 +0100 X-SourceIP: 85.127.82.165 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Ya7mg-0000an-M5; Mon, 23 Mar 2015 20:13:10 +0100 User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100854 Archived-At: On Sun, Mar 22 2015, Stefan Monnier wrote: >> only `face' or `font-lock-face' specific quirk being that `anonymous >> faces' have to be treated like atoms. > > The fact that you can combine values by using a list is not true of > all properties (far from that). Well, I can, though it won't make sense in most cases, that's why I said "(though perhaps not particularly useful)". >> Also, am I wrong that foo-- is used for symbols which are private to >> the `foo' library whereas `private to emacs' is achieved by not >> documenting things in the manual? > > There's no such distinction. The "--" is just mean to say it's > "internal/private" for some largely unspecified definition of > "internal/private". I stand corrected. Indeed, a quick test indicates that more than half of the symbols of the shape `foo--' are defined outside of foo.el. (progn (require 'cl-lib) (require 'subr-x) (let ((all 0) (bad 0)) (mapatoms (lambda (sym) (let ((name (symbol-name sym))) (when (string-match "\\`\\(.*?\\)--" name) (when-let ((file (symbol-file sym))) (cl-incf all) (unless (string= (match-string 1 name) (file-name-base file)) (cl-incf bad))))))) (list bad all))) => (665 1040) in the emacs instance where I'm writing this. While I'd prefer consistency with font-lock-append-text-property and friends (in particular because it's just an old function, dusted off a bit), it seems that you deem it more important to adhere to current conventions for naming slightly obscure functions. So, font-lock--remove-face-from-text-property, perhaps.