From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Any problem with this patch? Date: Fri, 23 Mar 2007 10:46:44 +0100 Message-ID: <85648s47i3.fsf@lola.goethe.zz> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1174643285 9557 80.91.229.12 (23 Mar 2007 09:48:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2007 09:48:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Herbert Euler" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 23 10:47:59 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HUgNH-0002IL-Rn for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 10:47:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUgPA-0007i3-0v for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 04:49:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HUgOE-00079N-LM for emacs-devel@gnu.org; Fri, 23 Mar 2007 05:48:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HUgO9-00072y-Jx for emacs-devel@gnu.org; Fri, 23 Mar 2007 05:48:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUgO8-00072k-WB for emacs-devel@gnu.org; Fri, 23 Mar 2007 04:48:49 -0500 Original-Received: from mail-in-03.arcor-online.net ([151.189.21.43]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HUgME-0006Y2-Jq for emacs-devel@gnu.org; Fri, 23 Mar 2007 05:46:50 -0400 Original-Received: from mail-in-01-z2.arcor-online.net (mail-in-09-z2.arcor-online.net [151.189.8.21]) by mail-in-03.arcor-online.net (Postfix) with ESMTP id 130972CB049; Fri, 23 Mar 2007 10:46:46 +0100 (CET) Original-Received: from mail-in-13.arcor-online.net (mail-in-13.arcor-online.net [151.189.21.53]) by mail-in-01-z2.arcor-online.net (Postfix) with ESMTP id 04C0A28EF01; Fri, 23 Mar 2007 10:46:46 +0100 (CET) Original-Received: from lola.goethe.zz (dslb-084-061-035-141.pools.arcor-ip.net [84.61.35.141]) by mail-in-13.arcor-online.net (Postfix) with ESMTP id D465929D4E2; Fri, 23 Mar 2007 10:46:45 +0100 (CET) Original-Received: by lola.goethe.zz (Postfix, from userid 1002) id 0512F1C4F93F; Fri, 23 Mar 2007 10:46:44 +0100 (CET) In-Reply-To: (Herbert Euler's message of "Fri\, 23 Mar 2007 17\:33\:28 +0800") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68369 Archived-At: "Herbert Euler" writes: >>I can't reproduce this. Did you possibly apply the patch _manually_ >>(and overlooked that it removes one level of braces)? > > Sorry, the error was actually caused by my mistake when I manually > applied the patch. Yes, I counted braces wrong. And the file is > opened correctly now. At least there is no obvious problem I can > see. Since it fixes one warning (which might or might not be a problem) and since it got quite more testing than intended (I disassembled macro and its caller to make sure that it worked), I'm confident enough to check this in now. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum