From: David Kastrup <dak@gnu.org>
To: "Herbert Euler" <herberteuler@hotmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Any problem with this patch?
Date: Fri, 23 Mar 2007 10:46:44 +0100 [thread overview]
Message-ID: <85648s47i3.fsf@lola.goethe.zz> (raw)
In-Reply-To: <BAY143-F404344FF1B6264D8374779DA6A0@phx.gbl> (Herbert Euler's message of "Fri\, 23 Mar 2007 17\:33\:28 +0800")
"Herbert Euler" <herberteuler@hotmail.com> writes:
>>I can't reproduce this. Did you possibly apply the patch _manually_
>>(and overlooked that it removes one level of braces)?
>
> Sorry, the error was actually caused by my mistake when I manually
> applied the patch. Yes, I counted braces wrong. And the file is
> opened correctly now. At least there is no obvious problem I can
> see.
Since it fixes one warning (which might or might not be a problem) and
since it got quite more testing than intended (I disassembled macro
and its caller to make sure that it worked), I'm confident enough to
check this in now.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-03-23 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 8:59 Any problem with this patch? David Kastrup
2007-03-23 9:18 ` Herbert Euler
2007-03-23 9:27 ` David Kastrup
2007-03-23 9:33 ` Herbert Euler
2007-03-23 9:46 ` David Kastrup [this message]
2007-03-23 9:19 ` Herbert Euler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85648s47i3.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=herberteuler@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.