From: Dmitry Gutov <dgutov@yandex.ru>
To: Winston <wbe@psr.com>, 28403@debbugs.gnu.org
Subject: bug#28403: 25.2; find-tag works, but xref-find-definitions
Date: Sun, 10 Sep 2017 12:01:08 +0300 [thread overview]
Message-ID: <85628b7a-3be1-0bea-57d5-1346589f7b8a@yandex.ru> (raw)
In-Reply-To: <201709100250.v8A2o6nL015568@psr.com>
On 9/10/17 5:49 AM, Winston wrote:
> Yes, and "etags --version" prints: etags (GNU Emacs 25.2)
Thanks.
> Exactly. E.g.,
> name _ARGS1(^?188,5710
>
>> which is an "implicit tag name" entry for "_ARGS1", but not for "name".
>> IOW, etags doesn't understand macros.
>
> Whether etags understands macros or not, it is correctly identifying
> the lines containing function names, so I see no problem there.
It has a line, but it's a line for tag name "_ARGS1", not "name", by
etags rules. find-tag just falls back to full text search, which
xref-find-definitions doesn't, by default.
Because false positives will be more noticeable and annoying in its UI,
compared to find-tag's.
>> Try adding `tag-symbol-match-p' to
>> etags-xref-find-definitions-tag-order. This example should work then,
>> but you'll get more false positives (like treating return types as
>> function names).
>
> Noted for future reference...
>
> Since doing that doesn't change what etags writes to TAGS, I'm not
> sure how that elisp change would result in function return types being
> matched as function names, but no matter.
Have you even tried this?
> For the moment I think I'll
> just continue to use find-tag and hope that xref-find-definitions will
> eventually work as well as find-tag before find-tag disappears. :)
It works better already (more precise results, for inputs that etags
understands well).
next prev parent reply other threads:[~2017-09-10 9:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 22:40 bug#28403: 25.2; find-tag works, but xref-find-definitions doesn't; bug? Winston
2017-09-09 22:58 ` Drew Adams
2017-09-09 23:10 ` Dmitry Gutov
2017-09-10 2:50 ` bug#28403: 25.2; find-tag works, but xref-find-definitions Winston
2017-09-10 9:01 ` Dmitry Gutov [this message]
2017-09-10 14:29 ` Eli Zaretskii
2017-09-10 21:43 ` Dmitry Gutov
2017-09-11 2:38 ` Eli Zaretskii
2017-09-11 8:58 ` Dmitry Gutov
2017-09-11 14:43 ` Eli Zaretskii
2017-09-12 23:40 ` Dmitry Gutov
2017-09-13 15:32 ` Eli Zaretskii
2017-09-14 12:13 ` Dmitry Gutov
2017-09-14 17:13 ` Eli Zaretskii
2017-09-19 0:44 ` Dmitry Gutov
2017-09-19 3:58 ` Eli Zaretskii
2017-09-10 14:52 ` Winston
2017-09-10 18:27 ` Winston
2017-09-10 19:09 ` Eli Zaretskii
2017-09-10 19:06 ` Winston
2017-09-10 19:10 ` Winston
2017-09-10 20:12 ` Winston
2017-09-11 2:31 ` Eli Zaretskii
2017-09-10 21:19 ` Winston
2017-09-10 21:35 ` Dmitry Gutov
2017-09-11 2:34 ` Eli Zaretskii
2017-09-11 3:19 ` Winston
2017-09-11 4:05 ` Winston
2017-09-11 16:23 ` Eli Zaretskii
2017-09-11 4:11 ` Winston
2017-09-11 5:02 ` Winston
2017-09-11 16:51 ` Eli Zaretskii
2017-09-14 17:37 ` Winston
2017-09-14 22:08 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85628b7a-3be1-0bea-57d5-1346589f7b8a@yandex.ru \
--to=dgutov@yandex.ru \
--cc=28403@debbugs.gnu.org \
--cc=wbe@psr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.