From: David Kastrup <dak@gnu.org>
Cc: cyd@stupidchicken.com, storm@cua.dk, emacs-devel@gnu.org
Subject: Re: local keymap patch for key-binding
Date: Wed, 13 Sep 2006 17:25:10 +0200 [thread overview]
Message-ID: <854pvbiyax.fsf@lola.goethe.zz> (raw)
In-Reply-To: <E1GNWNM-0005zY-Ea@fencepost.gnu.org> (Richard Stallman's message of "Wed\, 13 Sep 2006 11\:10\:08 -0400")
Richard Stallman <rms@gnu.org> writes:
> It looks like your patch does three things:
>
> 1. Makes Fkey_binding handle all the maps properly.
> 2. Implements a new arg LOCATION.
> 3. Changes something else in keyboard.c for motives that were
> never explained.
>
> Is there some reason why we need to add the LOCATION arg feature
> now?
Things like the follow-link property don't work consistently. The
keymaps where follow-link entries have an effect are not the same than
the keymaps where the mouse events are stored.
This inconsistency is annoying and unpredictable to application
programmers.
> I think we should not add it now if we don't really need to.
One actually needs something like the location argument (I reworked
this into a POSITION argument in the next patch, with position being
something like `event-start' returns) in order to have
`command-remapping' work on the same maps when it is called by
`key-binding'.
> I already asked for an explanation of the purpose of the other
> change in keyboard.c.
Probably a miscommunication, or crossing mails. I think I explained
it a few times already. But again: if we have both a `keymap' and
`local-map' text property in the buffer, the resulting behavior is
inconsistent with the documentation of keymap lookup: one of those
properties then gets ignored. The cost of making it consistent with
the documentation is negligible both in amounts of code (maybe 4
lines) as well as performance (probably sub-microsecond). So I
consider it a bugfix worth doing, even though I don't know of anybody
who has yet been bitten by this bug.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2006-09-13 15:25 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 9:34 longlines-mode doesn't seem to work with some non-english text Miles Bader
2006-02-11 4:35 ` Chong Yidong
2006-02-13 0:32 ` Kevin Ryde
2006-09-09 15:08 ` local keymap patch for key-binding Chong Yidong
2006-09-09 15:15 ` David Kastrup
2006-09-09 15:26 ` Chong Yidong
2006-09-10 12:44 ` Chong Yidong
2006-09-10 13:25 ` David Kastrup
2006-09-11 2:36 ` Chong Yidong
2006-09-11 6:25 ` David Kastrup
2006-09-11 7:05 ` David Kastrup
2006-09-11 8:52 ` Kim F. Storm
2006-09-11 9:48 ` David Kastrup
2006-09-11 10:11 ` David Kastrup
2006-09-11 12:53 ` Kim F. Storm
2006-09-11 13:04 ` David Kastrup
2006-09-11 13:07 ` Chong Yidong
2006-09-11 19:58 ` Richard Stallman
2006-09-12 10:04 ` David Kastrup
2006-09-12 15:21 ` David Kastrup
2006-09-12 15:39 ` PCL-CVS's diff and marks (was: local keymap patch for key-binding) Stefan Monnier
2006-09-12 15:42 ` PCL-CVS's diff and marks David Kastrup
2006-09-12 15:54 ` Stefan Monnier
2006-09-12 21:45 ` local keymap patch for key-binding Richard Stallman
2006-09-12 22:23 ` David Kastrup
2006-09-12 23:44 ` David Kastrup
2006-09-13 7:45 ` Kim F. Storm
2006-09-13 8:11 ` David Kastrup
2006-09-13 11:05 ` Kim F. Storm
2006-09-13 11:38 ` David Kastrup
2006-09-13 12:23 ` Kim F. Storm
2006-09-13 12:32 ` David Kastrup
2006-09-13 13:45 ` Kim F. Storm
2006-09-13 19:25 ` Richard Stallman
2006-09-13 19:49 ` David Kastrup
2006-09-13 19:25 ` Richard Stallman
2006-09-13 20:02 ` David Kastrup
2006-09-13 19:24 ` Richard Stallman
2006-09-13 15:10 ` Richard Stallman
2006-09-13 15:25 ` David Kastrup [this message]
2006-09-14 2:34 ` Richard Stallman
2006-09-14 11:57 ` David Kastrup
2006-09-14 22:34 ` David Kastrup
2006-09-14 22:36 ` David Kastrup
2006-09-15 3:14 ` Richard Stallman
2006-09-15 8:20 ` David Kastrup
2006-09-15 23:47 ` David Kastrup
2006-09-16 0:14 ` Kim F. Storm
2006-09-16 19:05 ` Richard Stallman
2006-09-18 15:43 ` David Kastrup
2006-09-18 20:34 ` Kim F. Storm
2006-09-18 23:39 ` Richard Stallman
2006-09-16 16:41 ` Stefan Monnier
2006-09-10 18:52 ` Richard Stallman
2006-09-11 2:39 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=854pvbiyax.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.