From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.bugs Subject: bug#20066: 24.4; should-error and cl-assert Date: Mon, 09 Mar 2015 17:12:35 +0100 Message-ID: <854mpum9nj.fsf@iznogoud.viz> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1425917666 12770 80.91.229.3 (9 Mar 2015 16:14:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Mar 2015 16:14:26 +0000 (UTC) Cc: 20066@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 09 17:14:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YV0Jo-0006hT-WA for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2015 17:14:13 +0100 Original-Received: from localhost ([::1]:44157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV0Jo-0005ly-75 for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Mar 2015 12:14:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV0Ji-0005ho-W4 for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2015 12:14:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YV0Je-0004oM-J0 for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2015 12:14:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV0Je-0004oI-GY for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2015 12:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YV0Je-00066N-1X for bug-gnu-emacs@gnu.org; Mon, 09 Mar 2015 12:14:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Mar 2015 16:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20066-submit@debbugs.gnu.org id=B20066.142591761123406 (code B ref 20066); Mon, 09 Mar 2015 16:14:01 +0000 Original-Received: (at 20066) by debbugs.gnu.org; 9 Mar 2015 16:13:31 +0000 Original-Received: from localhost ([127.0.0.1]:40876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YV0J9-00065S-8o for submit@debbugs.gnu.org; Mon, 09 Mar 2015 12:13:31 -0400 Original-Received: from b2bfep13.mx.upcmail.net ([62.179.121.58]:33066) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YV0J6-00065C-1J for 20066@debbugs.gnu.org; Mon, 09 Mar 2015 12:13:29 -0400 Original-Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep13.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150309161321.VSES20529.b2bfep13-int.chello.at@edge12.upcmail.net> for <20066@debbugs.gnu.org>; Mon, 9 Mar 2015 17:13:21 +0100 Original-Received: from iznogoud.viz ([91.119.102.48]) by edge12.upcmail.net with edge id 1UDM1q00112fMZF0CUDM5R; Mon, 09 Mar 2015 17:13:21 +0100 X-SourceIP: 91.119.102.48 Original-Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YV0Iy-0000Mt-OP; Mon, 09 Mar 2015 17:13:20 +0100 User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100327 Archived-At: On Mon, Mar 09 2015, Leo Liu wrote: > I just compiled emacs 25.0.50 from git and I have immediately noticed > the following difference: > > 1. (should-error (error "yes")) > 2. (should-error (cl-assert nil t)) > > Test 1 succeeds but test 2 fails. In emacs 24.4, both tests succeed. > Could someone investigate what have caused this incompatibility? commit 61b4c22c6eba96718327a0d208a8492d8bad76e0 Author: Stefan Monnier Date: Sat Feb 14 00:46:29 2015 -0500 [...] (cl--assertion-failed): New function. +(defun cl--assertion-failed (form &optional string sargs args) + (if debug-on-error + (debug `(cl-assertion-failed ,form ,string ,@sargs)) So, `debug' is explicitly called now, which circumvents the normal call-chain: signal > maybe_call_debugger > call_debugger > debug