From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list Date: Wed, 13 May 2020 10:29:31 -0400 Message-ID: <854ksjhpro.fsf@gmail.com> References: <87eez3kebf.fsf@gnus.org> <87v9lbykbp.fsf@stefankangas.se> <87tv0veuyh.fsf@gmail.com> <87eerzyhbi.fsf@stefankangas.se> <87r1vpogto.fsf@gmail.com> <87ftc4ukv1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="115987"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) Cc: Lars Ingebrigtsen , Stefan Kangas , 29533@debbugs.gnu.org To: stardiviner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 13 16:30:58 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYsPR-000U2t-1L for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 May 2020 16:30:57 +0200 Original-Received: from localhost ([::1]:43974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYsPQ-0002w1-0X for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 May 2020 10:30:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYsOa-0002Pm-7R for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 10:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYsOZ-0001Pf-44 for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 10:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYsOY-0002HF-0G for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 10:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 May 2020 14:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29533 X-GNU-PR-Package: emacs Original-Received: via spool by 29533-submit@debbugs.gnu.org id=B29533.15893801818703 (code B ref 29533); Wed, 13 May 2020 14:30:01 +0000 Original-Received: (at 29533) by debbugs.gnu.org; 13 May 2020 14:29:41 +0000 Original-Received: from localhost ([127.0.0.1]:59037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYsOD-0002GJ-9l for submit@debbugs.gnu.org; Wed, 13 May 2020 10:29:41 -0400 Original-Received: from mail-qv1-f49.google.com ([209.85.219.49]:34444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYsOB-0002G5-8I for 29533@debbugs.gnu.org; Wed, 13 May 2020 10:29:39 -0400 Original-Received: by mail-qv1-f49.google.com with SMTP id r3so8303749qvm.1 for <29533@debbugs.gnu.org>; Wed, 13 May 2020 07:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gq+XDKb7/GjLXuJIF7UhG2lfmwdEEtRnmbDjDNZ1828=; b=KFbwSio2tPCsGGeUzzvpVquhVGLl+YfamiHV96gE1nJLx4m0i//QvBk+UUyzR2WRZ6 /ZG4uWlc47q4Qp+Ikcc9/H8AFo8gXR4YRefq17tXV29hbWNB/T50/FYWS5IxxdKkUYYx a/gmsKxlQzZTdycxXJvabzuEFra53aVp+VPrSiAsolqeomyrMa877/5SM6HcBPQ0MgpF hNQNW4faJG0u0OvKdknv5WcnOKA4HABTXiQDD+Gj2NiI+BY0VmeQijCMb6CAqRgQcUux j+1Xr1EMxii8o212/txkEgAzi4Lt1FNoHHl/9X9bNlGwprIOpLASQRyVFAxc7mj7w4b2 C5Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=gq+XDKb7/GjLXuJIF7UhG2lfmwdEEtRnmbDjDNZ1828=; b=HsjOgXtjncc1iXahndmiRc7/GwNS5CXK2Vzmy6V9Riu+XsWMcfvd3fFiTb7a6rJIs9 1d8HXnyck0C5J7WcE/SY0se8PpKwy+X7qk8PpcBd4xK5cLQq8aUFa2SAbxM6rAenP4SO L4l+kprldgoQkrOETKIQx8lu0qbBRR6ivyoM1lWbsZ2hSTkv8afIr7MmIQqBN5AI1dF7 eCoooXxgOoI9jPPH2CWCBMZFpPyGSpVPu+vHCsgHvpot/Q1Iy7Av+GmOgQGxGt0edc2R VmhLKe11ibV7UwgLTthdmphKeCuAlrfcFYmunSOQtcfbvAyeOfzgQucoAcrdoddm6YDy /3SA== X-Gm-Message-State: AOAM532KFh3Vbch+gXX7QeuFoc3jxoaj+NMzzltcXwV8kPvb9aOeww00 ukLj6VX3qQvcyEj8jzIKnaGLKaz2 X-Google-Smtp-Source: ABdhPJztgXzHkBucv6dgyPwXaklqQbvSrz9wL42wBBnUGW649KEbrtMIU2FRPFMED/s10s1KcY4BYQ== X-Received: by 2002:a0c:8c4f:: with SMTP id o15mr13359122qvb.201.1589380173403; Wed, 13 May 2020 07:29:33 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id t12sm13394221qkt.77.2020.05.13.07.29.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 May 2020 07:29:32 -0700 (PDT) In-Reply-To: <87ftc4ukv1.fsf@gmail.com> (stardiviner's message of "Wed, 13 May 2020 19:37:06 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180153 Archived-At: stardiviner writes: > ;;; original code > (defun erc-join-channel (channel &optional key) > "Join CHANNEL. > > If `point' is at the beginning of a channel name, use that as default." > (interactive > (list [...] > (defun erc-join-channel-select (args) > "Select a channel to join from alist of channels to." > (let ((channel (completing-read > "Select a channel: " > (cdr (assoc > (completing-read "Select a server: " > (mapcar 'car erc-join-channels-alist)) > erc-join-channels-alist))))) > (setq args (list channel)))) > (advice-add 'erc-join-channel :filter-args 'erc-join-channel-select) > When I press [C-c C-j] (erc-join-channel), the advice is added on function, > but seems not working. Don't know why, do you have any clue? I think advice doesn't affect interactive calls the way you expect. I forget the details of it, but anyway it's probably better to just remap instead, along the lines of: (defun erc-join-channel-select () "Select a channel to join from alist of channels to." (erj-join-channel (completing-read "Select a channel: " (cdr (assoc (completing-read "Select a server: " (mapcar 'car erc-join-channels-alist)) erc-join-channels-alist))))) (define-key erc-mode-map [remap erc-join-channel] 'erc-join-channel-select)