all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]]
@ 2019-06-11 11:59 Konstantin Kharlamov
  2019-06-11 12:03 ` bug#36167: Acknowledgement ([PATCH] Replace manually crafted hex regexes with [[:xdigit:]]) Konstantin Kharlamov
                   ` (6 more replies)
  0 siblings, 7 replies; 43+ messages in thread
From: Konstantin Kharlamov @ 2019-06-11 11:59 UTC (permalink / raw)
  To: 36167

Hopefully, this is more readable compared to older "[0-9a-fA-F]", 
because the intention is immediately obvious.

Fun fact: initially I started it because on my older Emacs this 
resulted in better performance; the difference was about 10x times. But 
I can't reproduce this on the current master anymore, i.e. the 
performance matches. Oh, well. I'm thus not sending the patch replacing 
[0-9] with [[:digit:]] because in terms of readability the intention is 
clear there, however replacing the hex regexes should still make code 
more readable.

P.S.: I'm not sure if the commit message looks okay, comments are 
welcome.







^ permalink raw reply	[flat|nested] 43+ messages in thread
[parent not found: <<ac570eed-c6f4-0d6d-fc1c-2f116d597bd7@cs.ucla.edu>]

end of thread, other threads:[~2019-07-08 12:11 UTC | newest]

Thread overview: 43+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-11 11:59 bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Konstantin Kharlamov
2019-06-11 12:03 ` bug#36167: Acknowledgement ([PATCH] Replace manually crafted hex regexes with [[:xdigit:]]) Konstantin Kharlamov
2019-06-11 12:29 ` bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] Konstantin Kharlamov
2019-06-11 13:03   ` Robert Pluim
2019-06-11 13:17     ` Konstantin Kharlamov
2019-06-11 13:30       ` Robert Pluim
2019-06-12  0:29         ` Konstantin Kharlamov
2019-06-12  2:42           ` Eli Zaretskii
2019-06-12  8:21           ` Robert Pluim
2019-06-12 11:19             ` Konstantin Kharlamov
2019-06-12 14:55               ` Eli Zaretskii
2019-06-12 16:39                 ` Konstantin Kharlamov
2019-06-12 16:51                   ` Eli Zaretskii
2019-06-12 17:09                     ` Konstantin Kharlamov
2019-06-12 21:33                       ` Lars Ingebrigtsen
2019-06-12 21:39                         ` Lars Ingebrigtsen
2019-06-12 22:17                         ` Andreas Schwab
2019-06-12 22:22                           ` Lars Ingebrigtsen
2019-06-12 22:48                             ` Konstantin Kharlamov
2019-06-11 13:32     ` npostavs
2019-06-11 14:36       ` Eli Zaretskii
2019-06-11 14:26 ` bug#36167: [PATCH] Replace manually crafted hex regexes " Paul Eggert
2019-06-11 14:37   ` Konstantin Kharlamov
2019-06-11 15:37     ` Paul Eggert
2019-06-11 16:31       ` Mattias Engdegård
2019-06-11 16:50         ` Drew Adams
2019-06-11 17:04           ` Eli Zaretskii
2019-06-11 17:18             ` Paul Eggert
2019-06-11 17:32               ` Eli Zaretskii
2019-06-11 17:19             ` Drew Adams
2019-06-11 17:34               ` Eli Zaretskii
2019-06-11 17:50             ` npostavs
2019-06-11 17:53               ` Eli Zaretskii
2019-06-11 18:14                 ` Eli Zaretskii
2019-06-11 19:56 ` Andy Moreton
2019-06-12  2:30   ` Eli Zaretskii
2019-06-12 11:44 ` Andy Moreton
2019-06-12 16:07   ` Eli Zaretskii
2019-06-13  0:18 ` bug#36167: [PATCH v2] Replace manually crafted hex regexes wth [[:xdigit:]] Konstantin Kharlamov
2019-07-06  8:04   ` Eli Zaretskii
2019-07-08  9:34 ` bug#36167: [PATCH v2] Replace manually crafted hex regexes with [[:xdigit:]] Konstantin Kharlamov
2019-07-08 12:11   ` Eli Zaretskii
     [not found] <<ac570eed-c6f4-0d6d-fc1c-2f116d597bd7@cs.ucla.edu>
     [not found] ` <<1560263874.21373.1@yandex.ru>
     [not found]   ` <<5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu>
     [not found]     ` <<85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org>
     [not found]       ` <<be6e97d4-5040-47b5-b27b-6a52d2f46072@default>
     [not found]         ` <<83zhmo834p.fsf@gnu.org>
     [not found]           ` <<85zhmo9fk6.fsf@gmail.com>
     [not found]             ` <<83v9xc80uv.fsf@gnu.org>
     [not found]               ` <<83tvcw7zvq.fsf@gnu.org>
2019-06-11 19:01                 ` bug#36167: [PATCH] " Drew Adams

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.