From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Sun, 1 Jan 2023 18:24:32 +0100 Message-ID: <8538939b-5639-b8c0-82cc-113930a95ab1@secure.kjonigsen.net> References: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> <167e7ba3-ecb3-9e91-9a12-6020b4c1ec2b@secure.kjonigsen.net> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------JKscTIFRFGPPbRC6opEaS94u" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6686"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Cc: 60376@debbugs.gnu.org, Eli Zaretskii To: Yuan Fu , Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 18:25:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC25C-0001V6-8U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 18:25:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC252-00067X-O1; Sun, 01 Jan 2023 12:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC250-00067L-Vk for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC250-0007jT-Kb for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC250-0003sI-4w for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167259388314861 (code B ref 60376); Sun, 01 Jan 2023 17:25:02 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 1 Jan 2023 17:24:43 +0000 Original-Received: from localhost ([127.0.0.1]:41630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC24h-0003rd-86 for submit@debbugs.gnu.org; Sun, 01 Jan 2023 12:24:43 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC24f-0003rO-AV for 60376@debbugs.gnu.org; Sun, 01 Jan 2023 12:24:41 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 55EAD5C00C9; Sun, 1 Jan 2023 12:24:35 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 01 Jan 2023 12:24:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm1; t= 1672593875; x=1672680275; bh=kxMpB8UgnjTLqjdtQ2HbPNlQjWiY6xmJPxQ RlMDigWw=; b=slQWdCt7ds11gLuFTA+XTt4yJDs0MhnecjRtiSXf1CBK3FOxeXG wpbFZ7RpsUSWGs3FxHQLEQTH/2EZFtdKfdAnIvBxgSujv8jY+o3+k4aL+6cvvolZ plJI05AtcxlHQJnpBVmKJydkhMApw/oS/Y8kYwYefiLwhoj23ar6qawW0DkaKw8Z xSYvgQOPNdXhzyb0peh+nxAiNYD1LqFjxqb4o9wFPJ2dUsqBpCFYT3pTdTjiAwk6 PXsM89PWGpU897iEyiu1a/uKyP3aG+KrnkPI9Xz3TF6okofzkQYz2LpwSX3yZxqW eeuBmXiUdzh7XqJi4Bs76Py6wNc7XAZg+gQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1672593875; x=1672680275; bh=kxMpB8UgnjTLq jdtQ2HbPNlQjWiY6xmJPxQRlMDigWw=; b=gkwpSLVZzyxDLtV58ogftgo3CptUq Rtyz1IrbTdg1bOxKhyhxlhymWzyDjhZp66hD7LMhPqYsOyHghPeqCc6H6GLKacWi CdZgt32M+c/DRZ4hF/fNQPihLi8Zh4aTqnzAU0194U7dAgjseylC8iR4TfBxDcwQ FEfd19KSqMixUGLcO1SmYa4ZRPj2JOnsvKWke+r88kBxR7WVlBeYmK/AAepsnugO ctUC95V8jhUj/dwkt2ikAooiyRWDLITpsRMF3E2GQY1AbCZAH6wQ6NEldtbkQIpQ stx18eBD80ZJurZXjIYc++0C32hf/L2us6UXBJSIK713aiQTJ8P6302VQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedtgdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuhffvvehfjgesmhdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepueduffetfeeileffgfffveeihfej gfffvdehueekudehhfejieetvdfghfduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 12:24:34 -0500 (EST) Content-Language: en-GB, nb-NO In-Reply-To: <167e7ba3-ecb3-9e91-9a12-6020b4c1ec2b@secure.kjonigsen.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252257 Archived-At: This is a multi-part message in MIME format. --------------JKscTIFRFGPPbRC6opEaS94u Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01.01.2023 17:29, Jostein Kjønigsen wrote: > On 31.12.2022 23:21, Yuan Fu wrote: >> I applied it, thanks! >> >> Yuan > > Following up this case, attached is a patch which from what I can tell > movies function invocation fontification to level 4, without any other > regressions. > > Theo: Care to take it for a spin? Does it look OK by you? > > -- > Jostein Disregard previous patch. Consider instead please the patch attached to this email. It does 3 things all in one: * moves function-call fontification to level 4 only (in its own feature) * cleans up long-standing issues with "messy" rules for function-invocations. Removes the needs for "overrides". * also fixes issue with fonctification of self/this-method invocations. Theo: Can you try this patch and see what you think? -- Jostein --------------JKscTIFRFGPPbRC6opEaS94u Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-csharp-mode.el-adjust-function-call-f.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-csharp-mode.el-adjust-function-call-f.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYjNkZjdiNzczNTdhNTZkYTllMDUxNjNlZjBiZjBjYTllZmE5N2RiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU3VuLCAxIEphbiAyMDIzIDE3 OjI3OjA2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1v ZGUuZWw6IGFkanVzdCBmdW5jdGlvbi1jYWxsCiBmb250aWZpY2F0aW9uCgotLS0KIGxpc3Av cHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsIHwgNDMgKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyMyBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9kZS5lbCBi L2xpc3AvcHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsCmluZGV4IGRhNjRkYWY5ODQ4Li4wMmRh NzA1YjQ0NSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwKKysr IGIvbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwKQEAgLTc2NCw4ICs3NjQsMTIgQEAg Y3NoYXJwLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogICAgICAgKGlkZW50aWZpZXIp IEBmb250LWxvY2stdHlwZS1mYWNlKQogICAgICAodHlwZV9hcmd1bWVudF9saXN0CiAgICAg ICAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpCi0gICAgIChnZW5lcmljX25h bWUKLSAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKKyAgICAgKHR5 cGVfYXJndW1lbnRfbGlzdAorICAgICAgKGdlbmVyaWNfbmFtZQorICAgICAgIChpZGVudGlm aWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkpCisgICAgIChiYXNlX2xpc3QKKyAgICAgIChn ZW5lcmljX25hbWUKKyAgICAgICAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2Up KQogICAgICAoYXJyYXlfdHlwZQogICAgICAgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlw ZS1mYWNlKQogICAgICAoY2FzdF9leHByZXNzaW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LXR5cGUtZmFjZSkKQEAgLTgxMCwyNiArODE0LDYgQEAgY3NoYXJwLXRzLW1vZGUtLWZvbnQt bG9jay1zZXR0aW5ncwogICAgICAobWV0aG9kX2RlY2xhcmF0aW9uIHR5cGU6IChfKSBAZm9u dC1sb2NrLXR5cGUtZmFjZSkKICAgICAgKG1ldGhvZF9kZWNsYXJhdGlvbiBuYW1lOiAoXykg QGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAKLSAgICAgKGludm9jYXRpb25fZXhw cmVzc2lvbgotICAgICAgKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lvbgotICAgICAgIChnZW5l cmljX25hbWUgKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKSkp Ci0gICAgIChpbnZvY2F0aW9uX2V4cHJlc3Npb24KLSAgICAgIChtZW1iZXJfYWNjZXNzX2V4 cHJlc3Npb24KLSAgICAgICAoKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFt ZS1mYWNlCi0gICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUt ZmFjZSkpKQotICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCi0gICAgICAoaWRlbnRpZmll cikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCi0gICAgIChpbnZvY2F0aW9uX2V4 cHJlc3Npb24KLSAgICAgIChtZW1iZXJfYWNjZXNzX2V4cHJlc3Npb24KLSAgICAgICBleHBy ZXNzaW9uOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQot ICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCi0gICAgICBmdW5jdGlvbjogWyhnZW5lcmlj X25hbWUgKGlkZW50aWZpZXIpKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZQotICAg ICAgICAgICAgICAgICAoZ2VuZXJpY19uYW1lICh0eXBlX2FyZ3VtZW50X2xpc3QKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgWyI8Il0gQGZvbnQtbG9jay1icmFja2V0LWZh Y2UKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdHlwZS1mYWNlCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFsiPiJd IEBmb250LWxvY2stYnJhY2tldC1mYWNlKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICldKQotCiAgICAgIChjYXRjaF9kZWNsYXJhdGlvbgogICAgICAgKChpZGVudGlmaWVy KSBAZm9udC1sb2NrLXR5cGUtZmFjZSkpCiAgICAgIChjYXRjaF9kZWNsYXJhdGlvbgpAQCAt ODQ1LDYgKzgyOSwxOSBAQCBjc2hhcnAtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAg ICAgIChiaW5hcnlfZXhwcmVzc2lvbiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJs ZS1uYW1lLWZhY2UpCiAgICAgIChhcmd1bWVudCAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12 YXJpYWJsZS1uYW1lLWZhY2UpKQogCisgICA6bGFuZ3VhZ2UgJ2Mtc2hhcnAKKyAgIDpmZWF0 dXJlICdmdW5jdGlvbgorICAgJygoaW52b2NhdGlvbl9leHByZXNzaW9uCisgICAgICBmdW5j dGlvbjogKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lvbgorICAgICAgICAgICAgICAgICBuYW1l OiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpKQorICAgICAo aW52b2NhdGlvbl9leHByZXNzaW9uCisgICAgICBmdW5jdGlvbjogKGlkZW50aWZpZXIpIEBm b250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQorICAgICAoaW52b2NhdGlvbl9leHByZXNz aW9uCisgICAgICBmdW5jdGlvbjogKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lvbgorICAgICAg ICAgICAgICAgICBuYW1lOiAoZ2VuZXJpY19uYW1lIChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LWZ1bmN0aW9uLW5hbWUtZmFjZSkpKQorICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCisg ICAgICBmdW5jdGlvbjogKGdlbmVyaWNfbmFtZSAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1m dW5jdGlvbi1uYW1lLWZhY2UpKSkKKwogICAgOmxhbmd1YWdlICdjLXNoYXJwCiAgICA6ZmVh dHVyZSAnZXNjYXBlLXNlcXVlbmNlCiAgICA6b3ZlcnJpZGUgdApAQCAtOTE2LDcgKzkxMyw3 IEBAIGNzaGFycC10cy1tb2RlCiAgICAgICAgICAgICAgICcoKCBjb21tZW50IGRlZmluaXRp b24pCiAgICAgICAgICAgICAgICAgKCBrZXl3b3JkIHN0cmluZyB0eXBlKQogICAgICAgICAg ICAgICAgICggY29uc3RhbnQgZXNjYXBlLXNlcXVlbmNlIGV4cHJlc3Npb24gbGl0ZXJhbCBw cm9wZXJ0eSkKLSAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVyIGVycm9yKSkp CisgICAgICAgICAgICAgICAgKCBmdW5jdGlvbiBicmFja2V0IGRlbGltaXRlciBlcnJvcikp KQogCiAgIDs7IEltZW51LgogICAoc2V0cS1sb2NhbCB0cmVlc2l0LXNpbXBsZS1pbWVudS1z ZXR0aW5ncwotLSAKMi4zNy4yCgo= --------------JKscTIFRFGPPbRC6opEaS94u--