all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Wolfgang Jenkner <wjenkner@inode.at>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 21067@debbugs.gnu.org
Subject: bug#21067: 25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob
Date: Sun, 19 Jul 2015 03:36:38 +0200	[thread overview]
Message-ID: <85380ludu0.fsf@iznogoud.viz> (raw)
In-Reply-To: <85lheh8ekr.fsf@iznogoud.viz>

On Sun, Jul 19 2015, Dmitry Gutov wrote:

> I like the idea, but FWIW the patch breaks diff-hl-revert-hunk
> (diff-hl is in GNU ELPA). Haven't investigated it further yet.

If I read diff-hl-revert-hunk correctly the code in vc-exec-after
expects point where (the synchronous call to) vc-diff-internal left it,
which should not be at eob, which is exactly where my patch would put
it :-(

It seems some code (not so far) out there uses synchronous calls for
a reason and also does much more weird things in vc-exec-after than I'd
have thought.

So, I'd rather just accept that the synchronous and asynchronous case
behave in different ways and scrap my proposed patch.

Thanks for pointing out this example.

> And the particular bug you've described, naturally, can also be fixed
> by making vc-hg-print-log asynchronous:

If all -print-log backend functions can be made asynchronous there's
nothing left to fix in the frontend I guess...







  reply	other threads:[~2015-07-19  1:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 11:09 bug#21067: 25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob Wolfgang Jenkner
2015-07-19  0:08 ` Dmitry Gutov
2015-07-19  1:36   ` Wolfgang Jenkner [this message]
2015-07-19 11:05     ` Dmitry Gutov
2015-07-19 18:04     ` Dmitry Gutov
2015-07-24 14:14     ` Dmitry Gutov
2015-11-30  3:01       ` Dmitry Gutov
2021-05-10 11:28         ` Lars Ingebrigtsen
2021-05-10 11:57           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85380ludu0.fsf@iznogoud.viz \
    --to=wjenkner@inode.at \
    --cc=21067@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.